Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Fixes to Rails 3 deprecation warnings #31

Open
wants to merge 3 commits into from

1 participant

@craic

Hi
I've fixed a couple of Deprecation warnings in Rails 3.0.1/Ruby 1.9.2 by moving the require on the controller_extension into the top-level init.rb and using Rails.env instead of RAILS_ENV.

I had to change the test_helper to fake a Rails.env method. It passes tests in Ruby 1.8.7/Rails 2.3.8 and Ruby 1.9.2/Rails 3.0.1

Hope you can merge them into the plugin

--Rob Jones

@craic

I spoke too soon - the plugin works in both Ruby 1.8.7 / Rails 2.3.8 and Ruby 1.9.2 / Rails 3.0.1 and the tests pass in Ruby 1.8.7 but they crash in Ruby 1.9.2 - the issue is a Gem::LoadError

/Users/jones/.rvm/rubies/ruby-1.9.2-p0/lib/ruby/1.9.1/rubygems.rb:238:in `activate': can't activate actionpack (= 2.3.8, runtime) for [], already activated actionpack-3.0.1 for

Not sure what the issue is. I am running ruby 1.9.2 under rvm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
3  init.rb
@@ -1 +1,2 @@
-require File.join(File.dirname(__FILE__), 'rails', 'init')
+require File.join(File.dirname(__FILE__), 'lib', 'less', 'controller_extension') if Rails.env == 'development'
+
View
2  lib/less/more.rb
@@ -15,7 +15,7 @@
end
class Less::More
- HEADER = %{/*\n\n\n\n\n\tThis file was auto generated by Less (http://lesscss.org). To change the contents of this file, edit %s instead.\n\n\n\n\n*/}
+ HEADER = %{/*\n\n\n\n\n\tThis file was auto generated by Less (http://lesscss.org). To change the contents of this file, edit %s instead.\n\n\n\n\n*/\n}
class << self
# Less::More.compression = true/false --- compress generated css ? (default: false)
View
1  rails/init.rb
@@ -1 +0,0 @@
-require File.join(File.dirname(__FILE__), '..', 'lib', 'less', 'controller_extension') if RAILS_ENV == 'development'
View
6 test/test_helper.rb
@@ -12,9 +12,13 @@ def self.root
def self.backtrace_cleaner
ActiveSupport::BacktraceCleaner.new
end
+
+ def self.env
+ 'development'
+ end
end
-RAILS_ENV = 'development'
+#RAILS_ENV = 'development'
# load plugin
$LOAD_PATH << File.join(File.dirname(__FILE__), '..', 'lib')
Something went wrong with that request. Please try again.