Final 3.0 CLI touches #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reject Runner with real Errors. * Fix handling of --max-warnings=-1. Closes #321. * Fix a minor refactor typo with custom linters.
kokarn
reviewed
Feb 6, 2017
| status: EXIT_CODES.WARNING | ||
| }); | ||
| return reject(new RunnerError( | ||
| '', |
There was a problem hiding this comment.
Can't we avoid this empty message somehow?
There was a problem hiding this comment.
Are you suggesting we put a message there? Or something else?
There was a problem hiding this comment.
Not sure what to do, just don't like passing empty messages I guess.
Can't we have a default just to ease my mind or will that break something?
I guess it's stuff like if( error.message ) that scares me a bit.
There was a problem hiding this comment.
I don't wanna unnecessary output in case someone's piping the output somewhere else, reporters will already have printed everything that's needed.
There was a problem hiding this comment.
Hmm, I guess that makes sense. Just leaves me with a funny feeling.
kokarn
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runnerwith realErrors.--max-warnings=-1. Closes Max-Warnings Config Issue聽#321.Which issue, if any, does this resolve?
#321 among others.
Is there anything in this PR that needs extra explaining or should something specific be focused on?
@kokarn Is this what you had in mind? Hope I didn't step on any toes 馃槵