Browse files

deprecation warning, changelog entry

  • Loading branch information...
1 parent 5bcd119 commit 3a1d51959bf569a7419fe8ab9416b338334b4800 @lest committed Nov 22, 2011
Showing with 7 additions and 1 deletion.
  1. +4 −0 actionpack/CHANGELOG.md
  2. +3 −1 actionpack/lib/action_dispatch/middleware/show_exceptions.rb
View
4 actionpack/CHANGELOG.md
@@ -1,5 +1,9 @@
## Rails 3.2.0 (unreleased) ##
+* Refactor ActionDispatch::ShowExceptions. Controller is responsible for choice to show exceptions. *Sergey Nartimov*
+
+ It's possible to override +show_detailed_exceptions?+ in controllers to specify which requests should provide debugging information on errors.
+
* Responders now return 204 No Content for API requests without a response body (as in the new scaffold) *José Valim*
* Added ActionDispatch::RequestId middleware that'll make a unique X-Request-Id header available to the response and enables the ActionDispatch::Request#uuid method. This makes it easy to trace requests from end-to-end in the stack and to identify individual requests in mixed logs like Syslog *DHH*
View
4 actionpack/lib/action_dispatch/middleware/show_exceptions.rb
@@ -2,6 +2,7 @@
require 'action_controller/metal/exceptions'
require 'active_support/notifications'
require 'action_dispatch/http/request'
+require 'active_support/deprecation'
module ActionDispatch
# This middleware rescues any exception returned by the application and renders
@@ -38,7 +39,8 @@ class ShowExceptions
"application's log file and/or the web server's log file to find out what " <<
"went wrong.</body></html>"]]
- def initialize(app)
+ def initialize(app, consider_all_requests_local = nil)
+ ActiveSupport::Deprecation.warn "Passing consider_all_requests_local option to ActionDispatch::ShowExceptions middleware no longer works" unless consider_all_requests_local.nil?
@app = app
end

0 comments on commit 3a1d519

Please sign in to comment.