Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title attr to pages link #49

Merged
merged 1 commit into from Jan 21, 2017

Conversation

Projects
None yet
2 participants
@Mahjouba91
Copy link
Contributor

commented Jan 20, 2017

Hello,

A web accessibility expert from Temesis / Opquast have made an audit on a big french website (museum) and reported this following issue with WP pagenavi plugin about a11y.

It would be nice to have a title attribute explaining which page number is it for screen readers.

It would make a markup like this for example :
<a class="page larger" title="Page 3" href="/page/3/">3</a>

So here I'm proposing this Pull Request to handle this behavior, I didn't have to make so much changes thanks to the current base code, and I use i18n functions to allow this new text to be translatable.

Hope to find this approved, thanks for your job 馃槃

@lesterchan lesterchan merged commit 009f1e6 into lesterchan:master Jan 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lesterchan

This comment has been minimized.

Copy link
Owner

commented Jan 21, 2017

Thanks for this =)

@Mahjouba91

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2017

@lesterchan Hello, can you make a wordpress.org release for this PR please ?

@lesterchan

This comment has been minimized.

Copy link
Owner

commented Jun 30, 2017

@Mahjouba91 done =)

@Mahjouba91

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2017

Nice, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.