Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worker exiting detection #17

merged 3 commits into from Dec 10, 2018


None yet
2 participants
Copy link

commented Dec 7, 2018

Currently start-server kills old worker even if you failed to start a new worker.

In the Unix system, it was necessary to check the state of the process using wait4 instead of FindProcess.

On Unix systems, FindProcess always succeeds and returns a Process for the given pid, regardless of whether the process exists.

@lestrrat lestrrat merged commit 8564cc8 into lestrrat-go:master Dec 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Copy link

commented Dec 10, 2018


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.