New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile.PL #1

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@nric62
Contributor

nric62 commented Mar 13, 2015

Hi Daisuke Maki,
i'm new to Pull request (parecipating to PullRequest Challenge).
Trying to install the module on strawberry for Windows, there was error on compilation:

C:\STRAWB1\c\lib\libmpfr.a(clear.o):(.text+0x1e): undefined reference to __gmp_get_memory_functions' C:\STRAWB~1\c\lib\libmpfr.a(mul.o):(.text+0x4e4): undefined reference to__gmpn_mul'
C:\STRAWB
1\c\lib\libmpfr.a(mul.o):(.text+0x517): undefined reference to __gmpn_lshift' C:\STRAWB~1\c\lib\libmpfr.a(mul.o):(.text+0x7e7): undefined reference to__gmpn_lshift'

Looking at mpfr.org i've found this faq:

[from http://www.mpfr.org/faq.html#undef_ref1]
5. When I link my program with MPFR, I get undefined reference to __gmpXXXX.

Link your program with GMP. Assuming that your program is foo.c, you should link it using: 
    cc link.c -lmpfr -lgmp 
MPFR library reference (-lmpfr) should be before GMP's one (-lgmp). Another solution is, with GNU ld, to give all the libraries inside a group: 
    gcc link.c -Wl,--start-group libgmp.a libmpfr.a -Wl,--end-group 
See INSTALL file and ld manual for more details.

I've touched Makefile.pl and added gmp library.

Seems that the Makefile.pl is different in gitHub and in Cpan.

Have a nice day and CIAO
Ulderico

PS: excuse for my english

Update Makefile.PL
Error on windows distribution under Strawberry
@lestrrat

This comment has been minimized.

Collaborator

lestrrat commented Mar 16, 2015

@nric62 Hi. Tests on Travis CI failed so I looked into it, and it turns out I must've stopped short while trying to set things up a long time ago. I reinstated the tests, and I probably added a fix to your root cause.

Can you please check out current master branch and see if it works for you?

@nric62

This comment has been minimized.

Contributor

nric62 commented Mar 22, 2015

Hi lestrrat,

I've tried to install your new distribution, but i've found some matters:

  1. on windows distribution tar is not present
  2. you the lib mpfr ang gmp are present on strawberry distribution (so
    is not necessary to download)
  3. after some errors, i've done:
  • perl makefile.pl
  • dmake
  • dmake test
  1. the test signal me the following errors:# Failed test 'Got
    1903-06-22T23:57:14, expected 1903-06-23'

    at xt/101_solar_term.t line 23.

    got: '1903-06-22'

    expected: '1903-06-23'

    xt/101_solar_term.t ........... 367/?

    Failed test 'Got 1915-05-06T23:55:41, expected 1915-05-07'

    at xt/101_solar_term.t line 27.

    got: '1915-05-06'

    expected: '1915-05-07'

    xt/101_solar_term.t ........... 421/?

    Failed test 'Got 1917-09-23T23:52:53, expected 1917-09-24'

    at xt/101_solar_term.t line 23.

    got: '1917-09-23'

    expected: '1917-09-24'

    xt/101_solar_term.t ........... 448/?

    Failed test 'Got 1919-03-06T23:58:26, expected 1919-03-07'

    at xt/101_solar_term.t line 27.

    got: '1919-03-06'

    expected: '1919-03-07'

    xt/101_solar_term.t ........... 776/?

    Failed test 'Got 1932-10-23T23:56:42, expected 1932-10-24'

    at xt/101_solar_term.t line 23.

    got: '1932-10-23'

    expected: '1932-10-24'

    xt/101_solar_term.t ........... 1159/?

    Failed test 'Got 1948-05-06T00:45:05, expected 1948-05-05'

    at xt/101_solar_term.t line 27.

    got: '1948-05-06'

    expected: '1948-05-05'

    xt/101_solar_term.t ........... 1186/?

    Failed test 'Got 1950-01-20T23:52:57, expected 1950-01-21'

    at xt/101_solar_term.t line 23.

    got: '1950-01-20'

    expected: '1950-01-21'

    xt/101_solar_term.t ........... 1267/?

    Failed test 'Got 1953-01-05T23:55:14, expected 1953-01-06'

    at xt/101_solar_term.t line 27.

    got: '1953-01-05'

    expected: '1953-01-06'

    xt/101_solar_term.t ........... 1539/?

    Failed test 'Got 1964-09-07T23:52:46, expected 1964-09-08'

    at xt/101_solar_term.t line 27.

    got: '1964-09-07'

    expected: '1964-09-08'

    xt/101_solar_term.t ........... 1566/?

    Failed test 'Got 1965-11-07T23:59:25, expected 1965-11-08'

    at xt/101_solar_term.t line 27.

    got: '1965-11-07'

    expected: '1965-11-08'

    xt/101_solar_term.t ........... 1975/?

    Failed test 'Got 1982-10-08T23:55:10, expected 1982-10-09'

    at xt/101_solar_term.t line 27.

    got: '1982-10-08'

    expected: '1982-10-09'

    Failed test 'Got 1983-05-21T23:59:34, expected 1983-05-22'

    at xt/101_solar_term.t line 23.

    got: '1983-05-21'

    expected: '1983-05-22'

    xt/101_solar_term.t ........... 2699/?

    Failed test 'Got 2013-04-04T23:54:37, expected 2013-04-05'

    at xt/101_solar_term.t line 27.

    got: '2013-04-04'

    expected: '2013-04-05'

    xt/101_solar_term.t ........... 2891/?

    Failed test 'Got 2021-02-03T23:50:29, expected 2021-02-04'

    at xt/101_solar_term.t line 27.

    got: '2021-02-03'

    expected: '2021-02-04'

    xt/101_solar_term.t ........... 2946/?

    Failed test 'Got 2023-01-05T23:56:11, expected 2023-01-06'

    at xt/101_solar_term.t line 27.

    got: '2023-01-05'

    expected: '2023-01-06'

    xt/101_solar_term.t ........... 3000/?

    Failed test 'Got 2025-12-21T23:54:31, expected 2025-12-22'

    at xt/101_solar_term.t line 23.

    got: '2025-12-21'

    expected: '2025-12-22'

    xt/101_solar_term.t ........... 3111/?

    Failed test 'Got 2030-02-18T23:51:18, expected 2030-02-19'

    at xt/101_solar_term.t line 23.

    got: '2030-02-18'

    expected: '2030-02-19'

    xt/101_solar_term.t ........... 3138/? # Looks like you failed 17 tests
    of 3144.

    xt/101_solar_term.t ........... Dubious, test returned 17 (wstat 4352,
    0x1100)
    Failed 17/3144 subtests
    xt/999_leak.t ................. skipped: Test requires module
    'Test::Valgrind' b
    ut it's not found
    xt/999_pod-coverage.t ......... skipped: Test requires module
    'Test::Pod::Covera
    ge' but it's not found
    xt/999_pod.t .................. skipped: Test requires module
    'Test::Pod' but it
    's not found

I hope my test are interesting for you , i'm using
Summary of my perl5 (revision 5 version 20 subversion 1) configuration:
osname=MSWin32, osvers=6.3, archname=MSWin32-x64-multi-thread
uname='Win32 strawberry-perl 5.20.1.1 #1 Mon Sep 15 13:26:45 2014 x64'

Have a nice day
Ulderico

2015-03-16 1:42 GMT+01:00 lestrrat notifications@github.com:

@nric62 https://github.com/nric62 Hi. Tests on Travis CI failed so I
looked into it, and it turns out I must've stopped short while trying to
set things up a long time ago. I reinstated the tests, and I probably added
a fix to your root cause.

Can you please check out current master branch and see if it works for you?


Reply to this email directly or view it on GitHub
#1 (comment).

@lestrrat

This comment has been minimized.

Collaborator

lestrrat commented Mar 22, 2015

@nric62

What... tars???? I have no idea what you are talking about.

My question is "does the ORIGINAL problem still exist?". Remember, this is a Pull Request, and therefore we talk about one change that you would like to propose

@lestrrat

This comment has been minimized.

Collaborator

lestrrat commented Mar 29, 2015

I'm assuming this is okay. Closing.

@lestrrat lestrrat closed this Mar 29, 2015

lestrrat pushed a commit that referenced this pull request Aug 16, 2017

Merge pull request #1 from nric62/nric62-patch-1
Update 101_solar_term.t
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment