New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 101_solar_term.t #2

Merged
merged 3 commits into from Aug 16, 2017

Conversation

Projects
None yet
2 participants
@nric62
Contributor

nric62 commented Mar 29, 2015

Hi Dako,
excuse for my long time, but i have no experience with Astro and solar term.
I've verified that the test failed are near 23:xx and 00:xx.
In this way all test are ok on Strawberry and the installation was completed.

Thank for your courtesy
Ulderico

Update 101_solar_term.t
In this way all test are ok also on strawberry
@lestrrat

This comment has been minimized.

Collaborator

lestrrat commented Mar 29, 2015

Thank you!

  1. Please use 4 space indentation
  2. Please use "snake_case" instead of "camelCase"
  3. Can you please add a note "Allowing 1 day discrepancy to allow tests to pass" in the cmpDate functions so we can see what's going on when running tests?

nric62 added some commits Mar 30, 2015

Update 101_solar_term.t
use 4 space indentation
use "snake_case" instead of "camelCase"
add a note "Allowing 1 day discrepancy to allow tests to pass" in the cmpDate functions so we can see what's going on when running tests
Merge pull request #1 from nric62/nric62-patch-1
Update 101_solar_term.t

@lestrrat lestrrat merged commit 397776c into lestrrat-p5:master Aug 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lestrrat added a commit that referenced this pull request Aug 20, 2017

Checking in changes prior to tagging of version 1.02.
Changelog diff is:

diff --git a/Changes b/Changes
index 7ceb14e..bb99cf9 100644
--- a/Changes
+++ b/Changes
@@ -1,7 +1,10 @@
 Revision history for Perl extension DateTime-Astro

 {{$NEXT}}
+
+1.02 2017-08-20T10:28:44Z
     * Migrate to using Minilla for packaging
+    * Fix packaging details

 1.01 17 Aug 2017
     * Merged PRs #2, #4, #5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment