Join GitHub today
tests depend on Test::SharedFork explicitly #64
No, and it won't unless Test::TCP will stop (for any reason) requiring
On Apr 6, 2015 12:04 AM, "lestrrat" email@example.com wrote:
added a commit
this pull request
Apr 6, 2015
If you don't mind waiting some time then I'm willing to have a good look at those failures in following days (ATM I'm having extremely spotty net connection - just getting into travis logs took me 15 minutes...).
This PR comes from CPAN Pull Request challenge - I got LibZMQ2 dist assigned for april. For me this challenge it is an opportunity to make a habit out of github contributions and learn a thing or two about CPAN ecosystem in the process. I hope that my changes are beneficial to distributions they are against, but I can always be wrong or just not align with author wishes :-).
If you find change wrong or just controversial then feel free to reject such PR (or in this case revert), I'll be absolutely fine with that!
Well you're welcome to look at it. I suspect some breaking change on libczmq1 (the C library) but I haven't looked far enough to make any finer grained guesses.
Also, this repo is a bit peculiar for a Perl module as it contains many bindings all in one... beware of that fact when you look into other modules in the future ;)
Failing tests are a simple issue of new Test::TCP release not declaring its runtime dependencies correctly - IO::Socket::IP is needed on runtime, but declared as test-only dependency. In Travis run for ZMQ Test::TCP gets installed, but it does not pull IO::Socket::IP(due to --notest). So ZMQ tests have Test::TCP available, but it fails during 'use'.
I've created tokuhirom/Test-TCP#36 and if it gets released it should fix ZMQ travis failures.