support MySQL 5.7.6 or later #4

Closed
wants to merge 5 commits into
from

Projects

None yet

2 participants

@Songmu
Contributor
Songmu commented Oct 6, 2016

mysql_install_db is obsoleted at MySQL 5.7.6 or later and should use mysqld --initialize-insecure instead.

@lestrrat
Owner
lestrrat commented Oct 6, 2016

Hmm, what's with the test failure?

mysqltest.go
}
- mysqlBaseDir = resolved
+ filepath.Dir(filepath.Dir(mysqlBaseDir))
@lestrrat
lestrrat Oct 6, 2016 Owner

This stray line (which does nothing), and the next line was the problem for failures.
You need to specify the path to the installation dir, not the bin dir, which in travis' case is /usr, but because you were not properly using this line properly, the tests were failing.

@lestrrat lestrrat referenced this pull request Oct 6, 2016
Merged

support mysqld initialize #5

@lestrrat
Owner
lestrrat commented Oct 6, 2016

This has been merged via #5

@lestrrat lestrrat closed this Oct 6, 2016
@lestrrat
Owner
lestrrat commented Oct 6, 2016

Sorry, I didn't notice your commit. Please see #5 for other changes.

@Songmu
Contributor
Songmu commented Oct 6, 2016

Thank you! 🙆‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment