Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

zmq[23]_getsockopt_string() is broken + some typos for Socket.pm #2

Merged
merged 2 commits into from Apr 19, 2012

Conversation

Projects
None yet
2 participants
Contributor

shripchenko commented Apr 19, 2012

  • passing char** instead of void*
  • calling ZMQ::cal() instead of ZMQ::call()
Contributor

shripchenko commented Apr 19, 2012

it doesnt look like this code in Socket.pm is workable:

            sub recv {
                my $self = shift;
                my $msg  = shift;
                if ( ref $msg && eval { $msg->isa( 'ZMQ::Message' ) } ) {
                    $msg = $msg->{_msg};
                }
                ZMQ::call( "zmq_recv", $msg, @_ );
            }
            sub send {
                my $self = shift;
                my $msg  = shift;
                if ( ref $msg && eval { $msg->isa( 'ZMQ::Message' ) } ) {
                    $msg = $msg->{_msg};
                }
                ZMQ::call( "zmq_send", $msg, @_ );
            }

@lestrrat lestrrat added a commit that referenced this pull request Apr 19, 2012

@lestrrat lestrrat Merge pull request #2 from shripchenko/master
zmq[23]_getsockopt_string() is broken + some typos for Socket.pm
3a078f8

@lestrrat lestrrat merged commit 3a078f8 into lestrrat:master Apr 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment