All funcs need a return. Move File::Spec() out of the BEGIN block

leto · Aug 19, 2007 · ac9e9fd · ac9e9fd
1 parent f34ee6a
commit ac9e9fd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Ack.pm b/Ack.pm
@@ -28,6 +28,8 @@ our $is_cygwin;
 our $is_windows;
 our %type_wanted;
 
+use File::Spec ();
+
 BEGIN {
     %ignore_dirs = (
         '.git'  => 'Git',
@@ -78,7 +80,6 @@ BEGIN {
         xml         => [qw( xml dtd xslt )],
     );
 
-    use File::Spec ();
     $path_sep = File::Spec->catfile( '', '' );
     $path_sep = quotemeta( $path_sep );
 
@@ -435,7 +436,6 @@ $copyright
 This program is free software; you can redistribute it and/or modify it
 under the same terms as Perl itself.
 END_OF_VERSION
-
 }
 
 =head2 print_version_statement( $copyright )
@@ -472,6 +472,8 @@ sub load_colors {
 
     $ENV{ACK_COLOR_MATCH}    ||= 'black on_yellow';
     $ENV{ACK_COLOR_FILENAME} ||= 'bold green';
+
+    return;
 }
 
 =head2 is_interesting

diff --git a/ack-standalone b/ack-standalone
@@ -762,6 +762,8 @@ our $is_cygwin;
 our $is_windows;
 our %type_wanted;
 
+use File::Spec ();
+
 BEGIN {
     %ignore_dirs = (
         '.git'  => 'Git',
@@ -812,7 +814,6 @@ BEGIN {
         xml         => [qw( xml dtd xslt )],
     );
 
-    use File::Spec ();
     $path_sep = File::Spec->catfile( '', '' );
     $path_sep = quotemeta( $path_sep );
 
@@ -1100,7 +1101,6 @@ $copyright
 This program is free software; you can redistribute it and/or modify it
 under the same terms as Perl itself.
 END_OF_VERSION
-
 }
 
 
@@ -1122,6 +1122,8 @@ sub load_colors {
 
     $ENV{ACK_COLOR_MATCH}    ||= 'black on_yellow';
     $ENV{ACK_COLOR_FILENAME} ||= 'bold green';
+
+    return;
 }