Permalink
Browse files

Bug 712837 - Remove flakey test js1_5/extensions/regress-371636.js; r…

…=dmandelin

In the test js1_5/extensions/regress-371636.js, we time a loop over an Array
using Numbers as keys, then do the same loop again using Strings as keys.  The
test asserts that the time using Strings is less than 3 times as large as the
time using Numbers.  Naturally, when running the tests with high parallelism,
this tends to fail at random.  Since losing this optimization would be an
extremely serious perf bug, we would notice this immediately from our perf
tests.  There is no reason to keep this as a correctness test.

--HG--
extra : rebase_source : 1b24b3326154c2f34b0bc0e7cba51ad7e5924c97
  • Loading branch information...
1 parent 7e84c53 commit d06732cb2de2febd89d619739c61a001b4bf34a3 Terrence Cole committed Dec 22, 2011
Showing with 0 additions and 88 deletions.
  1. +0 −1 js/src/tests/js1_5/extensions/jstests.list
  2. +0 −87 js/src/tests/js1_5/extensions/regress-371636.js
@@ -131,7 +131,6 @@ script regress-369404.js
script regress-369696-01.js
script regress-369696-02.js
script regress-369696-03.js
-random-if(xulRuntime.OS=="WINNT") script regress-371636.js # bug 528284
script regress-372309.js
script regress-374589.js
script regress-375183.js
@@ -1,87 +0,0 @@
-/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
-/* ***** BEGIN LICENSE BLOCK *****
- * Version: MPL 1.1/GPL 2.0/LGPL 2.1
- *
- * The contents of this file are subject to the Mozilla Public License Version
- * 1.1 (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- * http://www.mozilla.org/MPL/
- *
- * Software distributed under the License is distributed on an "AS IS" basis,
- * WITHOUT WARRANTY OF ANY KIND, either express or implied. See the License
- * for the specific language governing rights and limitations under the
- * License.
- *
- * The Original Code is JavaScript Engine testing utilities.
- *
- * The Initial Developer of the Original Code is
- * Mozilla Foundation.
- * Portions created by the Initial Developer are Copyright (C) 2007
- * the Initial Developer. All Rights Reserved.
- *
- * Contributor(s): Igor Bukanov
- *
- * Alternatively, the contents of this file may be used under the terms of
- * either the GNU General Public License Version 2 or later (the "GPL"), or
- * the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),
- * in which case the provisions of the GPL or the LGPL are applicable instead
- * of those above. If you wish to allow use of your version of this file only
- * under the terms of either the GPL or the LGPL, and not to allow others to
- * use your version of this file under the terms of the MPL, indicate your
- * decision by deleting the provisions above and replace them with the notice
- * and other provisions required by the GPL or the LGPL. If you do not delete
- * the provisions above, a recipient may use your version of this file under
- * the terms of any one of the MPL, the GPL or the LGPL.
- *
- * ***** END LICENSE BLOCK ***** */
-
-//-----------------------------------------------------------------------------
-var BUGNUMBER = 371636;
-var summary = 'Numeric sort performance';
-var actual = false;
-var expect = '(tint/tstr < 3)=true';
-
-
-//-----------------------------------------------------------------------------
-test();
-//-----------------------------------------------------------------------------
-
-function test()
-{
- enterFunc ('test');
- printBugNumber(BUGNUMBER);
- printStatus (summary);
-
- function testint(power)
- {
- var N = 1 << power;
- var a = new Array(N);
- for (var i = 0; i != N; ++i)
- a[i] = (N-1) & (0x9E3779B9 * i);
- var now = Date.now;
- var t = now();
- a.sort();
- return now() - t;
- }
-
- function teststr(power)
- {
- var N = 1 << power;
- var a = new Array(N);
- for (var i = 0; i != N; ++i)
- a[i] = String((N-1) & (0x9E3779B9 * i));
- var now = Date.now;
- var t = now();
- a.sort();
- return now() - t;
- }
-
- var tint = testint(18);
- var tstr = teststr(18);
- print('int: ' + tint, 'str: ' + tstr, 'int/str: ' + (tint/tstr).toFixed(2));
-
- actual = '(tint/tstr < 3)=' + (tint/tstr < 3);
- reportCompare(expect, actual, summary);
-
- exitFunc ('test');
-}

0 comments on commit d06732c

Please sign in to comment.