Make PIR procedure source code length configurable, have a sane default and error on invalid input #17

Closed
leto opened this Issue May 10, 2010 · 4 comments

Projects

None yet

3 participants

@leto
Owner
leto commented May 10, 2010

Currently, stored procedures are only allowed to have 1000 characters maximum, and the source is truncated to 1000 characters, instead of error-ing on procedures that are too long.

What is a reasonable default maximum? This is a compile-time knob.

@davidfetter
Collaborator

1G is the usual in PostgreSQL

@theory
Collaborator
theory commented May 10, 2010

Why have a max at all?

@theory
Collaborator
theory commented May 10, 2010

Fetter explains to me via IRC that by "1G" he means 1GB. ISTM that we should go with whatever limitation is imposed by PostgreSQL and not worry about it. Either way, 1000 characters is far, far to small.

@leto
Owner
leto commented May 14, 2010

I've created a config.h which defines a default maximimum of 64KB. Who is writing subroutines that have a billion characters? In any case, it is easily changed at compile-time.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment