New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain MQTT LWT messages #516

Merged
merged 1 commit into from Oct 15, 2017

Conversation

Projects
None yet
2 participants
@zdzichu
Contributor

zdzichu commented Sep 22, 2017

Retaining will messages allows monitoring agent to receive full info about clients state.
Without retaining, the monitoring agent will only be informed about events (connect/connection lost) happening during agent's connection to broker. Any reconnect would cause monitoring agent to lose state.

retain MQTT LWT messages
Retaining will messages allows monitoring agent to receive full info about clients state.
Without retaining, the monitoring agent will only be informed about events (connect/connection lost) happening during agent's connection to broker. Any reconnect would cause monitoring agent to lose state.
@psy0rz

This comment has been minimized.

Show comment
Hide comment
@psy0rz

psy0rz Sep 23, 2017

Member

doesnt this use too much memory? i assume the espeasy has to store the message temporarely?

Member

psy0rz commented Sep 23, 2017

doesnt this use too much memory? i assume the espeasy has to store the message temporarely?

@zdzichu

This comment has been minimized.

Show comment
Hide comment
@zdzichu

zdzichu Sep 23, 2017

Contributor

It uses no memory on ESPEasy. Messages are stored by broker (MQTT server).

Contributor

zdzichu commented Sep 23, 2017

It uses no memory on ESPEasy. Messages are stored by broker (MQTT server).

@psy0rz psy0rz added this to the 2.1.0 milestone Sep 23, 2017

@psy0rz

This comment has been minimized.

Show comment
Hide comment
@psy0rz

psy0rz Oct 15, 2017

Member

ah right makes sense.. thanks!

Member

psy0rz commented Oct 15, 2017

ah right makes sense.. thanks!

@psy0rz psy0rz merged commit 08d4d81 into letscontrolit:mega Oct 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

TD-er added a commit to TD-er/ESPEasy that referenced this pull request Oct 18, 2017

retain MQTT LWT messages (#516)
Retaining will messages allows monitoring agent to receive full info about clients state.
Without retaining, the monitoring agent will only be informed about events (connect/connection lost) happening during agent's connection to broker. Any reconnect would cause monitoring agent to lose state.

susisstrolch pushed a commit to susisstrolch/ESPEasy that referenced this pull request Nov 3, 2017

Susis Strolch
Merge remote-tracking branch 'upstream/mega' into mega
* upstream/mega: (66 commits)
  ESP32 fix FreeRAM reporting
  ESP32 Rules/ADC/PWM
  ESP32 IRAM/Deepsleep
  First preparations for ESP32
  smooth out testing code
  test fixes
  fixed bug in oled upstream lib
  fix warnings
  Support both SSD1306 and SH1106 OLED in OLED_Framed plugin (#509)
  fix plugin id (starting with a 0 makes it octal in c++ :( )
  Plugin 073 - 7-segment display plugin TM1637/MAX7219
  [MH-Z19] Allow for B-version and add filtering (#525)
  Simple fix for MH-Z19 B version. #529
  retain MQTT LWT messages (#516)
  keep TASKS_PER_PAGE at default value of 4
  src/Hardware.ino: make it possible to use GPIO-0 (D3) as Pin_sd_cs (#508)
  WebServer.ino: enhance handle_SDfilelist() (#507)
  [SSD1306] Feature/oled 1306 library upgrade (#501)
  OLED framed improve header footer (#495)
  Dallas Plugin enhanced : no more "delay()" (#488)
  ...

Superpiffer referenced this pull request Feb 22, 2018

[issue #869] Added 'LWT' to last will topic and improved CPU load (#883)
* [issue #869] Added 'LWT' to last will topic and improved CPU load

See #869 for discussion on Last Will Topic.
Also changed the way it tried to reconnect to make it return a lot faster when connection is not (yet) possible and call the PubSubClient::loop() at a much slower pace to reduce CPU usage. (See #847)
This higher CPU load was probably introduced when fixing #683.

* [MQTT] Fix error reporting success status with longer payloads

Applied PR https://github.com/knolleary/pubsubclient/pull/360/files

* made MQTT_CALLBACK_SIGNATURE for esp32 functional

Applied PR knolleary/pubsubclient#336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment