Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retain MQTT LWT messages #516

Merged
merged 1 commit into from Oct 15, 2017
Merged

retain MQTT LWT messages #516

merged 1 commit into from Oct 15, 2017

Conversation

zdzichu
Copy link
Contributor

@zdzichu zdzichu commented Sep 22, 2017

Retaining will messages allows monitoring agent to receive full info about clients state.
Without retaining, the monitoring agent will only be informed about events (connect/connection lost) happening during agent's connection to broker. Any reconnect would cause monitoring agent to lose state.

Retaining will messages allows monitoring agent to receive full info about clients state.
Without retaining, the monitoring agent will only be informed about events (connect/connection lost) happening during agent's connection to broker. Any reconnect would cause monitoring agent to lose state.
@psy0rz
Copy link
Member

psy0rz commented Sep 23, 2017

doesnt this use too much memory? i assume the espeasy has to store the message temporarely?

@zdzichu
Copy link
Contributor Author

zdzichu commented Sep 23, 2017

It uses no memory on ESPEasy. Messages are stored by broker (MQTT server).

@psy0rz psy0rz added this to the 2.1.0 milestone Sep 23, 2017
@psy0rz psy0rz added the Type: Enhancement Improve something already present label Sep 23, 2017
@psy0rz
Copy link
Member

psy0rz commented Oct 15, 2017

ah right makes sense.. thanks!

@psy0rz psy0rz merged commit 08d4d81 into letscontrolit:mega Oct 15, 2017
TD-er pushed a commit to TD-er/ESPEasy that referenced this pull request Oct 18, 2017
Retaining will messages allows monitoring agent to receive full info about clients state.
Without retaining, the monitoring agent will only be informed about events (connect/connection lost) happening during agent's connection to broker. Any reconnect would cause monitoring agent to lose state.
Superpiffer referenced this pull request Feb 22, 2018
* [issue #869] Added 'LWT' to last will topic and improved CPU load

See #869 for discussion on Last Will Topic.
Also changed the way it tried to reconnect to make it return a lot faster when connection is not (yet) possible and call the PubSubClient::loop() at a much slower pace to reduce CPU usage. (See #847)
This higher CPU load was probably introduced when fixing #683.

* [MQTT] Fix error reporting success status with longer payloads

Applied PR https://github.com/knolleary/pubsubclient/pull/360/files

* made MQTT_CALLBACK_SIGNATURE for esp32 functional

Applied PR knolleary/pubsubclient#336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improve something already present
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants