Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country polygons needs expanding at the coast #178

Open
lynxlynxlynx opened this issue Mar 9, 2018 · 1 comment
Open

Country polygons needs expanding at the coast #178

lynxlynxlynx opened this issue Mar 9, 2018 · 1 comment
Labels
bug good first issue Easier issues appropriate for newcomers

Comments

@lynxlynxlynx
Copy link
Collaborator

lynxlynxlynx commented Mar 9, 2018

The "Other" area category currently has 73 entries. 1 is from an offshore French colony in Africa, 1 on Cyprus, but the rest are from the capital of Tanzania.

This means they are not counted toward Tanzania stats.

Both Cyprus (id 89288dd7-70e5-4cd2-98ba-f3f933d3488f) and Tanzania seem to suffer from the same problem, visible on the coast. The polys are too generalised and need buffering towards the sea.

The data is in backend-geo and you can see how it was imported here. Try regenerating TZ.json with a lower simplification factor. The seed folder has instructions on how to later make a permanent change in the database.

Look at the Bahari road or Toure Drive in Dar es Salaam. The currently missing trashpoints are between that and the beach, so make sure the new polygon covers it:
https://app.worldcleanupday.com

Updating the polygon is the good-first-issue part. Upstreaming will have to be handled by others. The json files are in geojson format, so you can open them directly in QGIS.

spectacle h21324

@lynxlynxlynx lynxlynxlynx added bug good first issue Easier issues appropriate for newcomers labels Mar 9, 2018
@lynxlynxlynx lynxlynxlynx changed the title Tanzania country polygon needs expanding at the coast Country polygons needs expanding at the coast Jul 23, 2018
@lynxlynxlynx
Copy link
Collaborator Author

If we ever switch to a spatially enabled database, we could work around this by checking the nearest country and using that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Easier issues appropriate for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant