From 04d83c442d1cd0da8cab4341013239222a2b9135 Mon Sep 17 00:00:00 2001 From: Daniel Wilkowski Date: Fri, 20 Mar 2020 00:56:53 +0100 Subject: [PATCH 1/3] Added .gitignore --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file mode 100644 index 000000000..4c36e385c --- /dev/null +++ b/.gitignore @@ -0,0 +1,2 @@ +.idea/ +vendor/ From dc6f00c16b87c3c5046418ed4533c0e5f7757e4f Mon Sep 17 00:00:00 2001 From: Daniel Wilkowski Date: Fri, 20 Mar 2020 00:57:24 +0100 Subject: [PATCH 2/3] Correct Functions::isEmpty() #275 --- src/Ouzo/Goodies/Utilities/Functions.php | 2 +- .../Ouzo/Goodies/Utilities/FunctionsTest.php | 22 +++++++++++++++++++ 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/src/Ouzo/Goodies/Utilities/Functions.php b/src/Ouzo/Goodies/Utilities/Functions.php index daa6c961e..7b6b3b3af 100644 --- a/src/Ouzo/Goodies/Utilities/Functions.php +++ b/src/Ouzo/Goodies/Utilities/Functions.php @@ -123,7 +123,7 @@ public static function notEmpty() public static function isEmpty() { return function ($object) { - return !empty($object); + return empty($object); }; } diff --git a/test/src/Ouzo/Goodies/Utilities/FunctionsTest.php b/test/src/Ouzo/Goodies/Utilities/FunctionsTest.php index d835e9d5f..75f065495 100644 --- a/test/src/Ouzo/Goodies/Utilities/FunctionsTest.php +++ b/test/src/Ouzo/Goodies/Utilities/FunctionsTest.php @@ -285,4 +285,26 @@ public function shouldCheckIfStringIsEqualIgnoringCaseToValue() $this->assertTrue(Functions::call(Functions::equalsIgnoreCase('value'), 'VaLuE')); $this->assertTrue(Functions::call(Functions::equalsIgnoreCase('VaLuE'), 'value')); } + + /** + * @test + */ + public function shouldBeEmpty() + { + // then + $this->assertFalse(Functions::call(Functions::isEmpty(), ['The Lannisters send their regards'])); + $this->assertTrue(Functions::call(Functions::isEmpty(), [])); + $this->assertTrue(Functions::call(Functions::isEmpty(), null)); + } + + /** + * @test + */ + public function shouldNotBeEmpty() + { + // then + $this->assertTrue(Functions::call(Functions::notEmpty(), ['The Lannisters send their regards'])); + $this->assertFalse(Functions::call(Functions::notEmpty(), [])); + $this->assertFalse(Functions::call(Functions::notEmpty(), null)); + } } From 6b823f78dfef84c91343e88c03a96636489fc854 Mon Sep 17 00:00:00 2001 From: Daniel Wilkowski Date: Fri, 20 Mar 2020 00:59:57 +0100 Subject: [PATCH 3/3] Add tests for isBlank() and notBlank() --- .../Ouzo/Goodies/Utilities/FunctionsTest.php | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/test/src/Ouzo/Goodies/Utilities/FunctionsTest.php b/test/src/Ouzo/Goodies/Utilities/FunctionsTest.php index 75f065495..846db8bbc 100644 --- a/test/src/Ouzo/Goodies/Utilities/FunctionsTest.php +++ b/test/src/Ouzo/Goodies/Utilities/FunctionsTest.php @@ -307,4 +307,26 @@ public function shouldNotBeEmpty() $this->assertFalse(Functions::call(Functions::notEmpty(), [])); $this->assertFalse(Functions::call(Functions::notEmpty(), null)); } + + /** + * @test + */ + public function shouldBeBlank() + { + // then + $this->assertFalse(Functions::call(Functions::isBlank(), 'Not blank')); + $this->assertTrue(Functions::call(Functions::isBlank(), ' ')); + $this->assertTrue(Functions::call(Functions::isBlank(), '')); + } + + /** + * @test + */ + public function shouldNotBeBlank() + { + // then + $this->assertTrue(Functions::call(Functions::notBlank(), 'Not blank')); + $this->assertFalse(Functions::call(Functions::notBlank(), ' ')); + $this->assertFalse(Functions::call(Functions::notBlank(), '')); + } }