New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECDSA account key support #1357

Merged
merged 1 commit into from Jan 14, 2016

Conversation

Projects
None yet
3 participants
@hlandau
Copy link
Contributor

hlandau commented Jan 7, 2016

Now that #1298 is in, support for ECDSA account keys can be added. This is in itself a tiny change; the main issue is proper testing.

@hlandau hlandau force-pushed the hlandauf:ecdsa-account-key-support branch from 3651526 to 183d1ab Jan 7, 2016

@jsha jsha added the r=jsha label Jan 12, 2016

@jsha

This comment has been minimized.

Copy link
Contributor

jsha commented Jan 12, 2016

LGTM. @jmhodges?

@rolandshoemaker

This comment has been minimized.

Copy link
Member

rolandshoemaker commented Jan 13, 2016

LGTM.

@hlandau

This comment has been minimized.

Copy link
Contributor Author

hlandau commented Jan 14, 2016

Do you want me to rebase this or?

@jsha

This comment has been minimized.

Copy link
Contributor

jsha commented Jan 14, 2016

A rebase would be great, thanks!

@hlandau hlandau force-pushed the hlandauf:ecdsa-account-key-support branch from 183d1ab to 5c9be53 Jan 14, 2016

@hlandau

This comment has been minimized.

Copy link
Contributor Author

hlandau commented Jan 14, 2016

@jsha Done.

jsha added a commit that referenced this pull request Jan 14, 2016

@jsha jsha merged commit 3ed7988 into letsencrypt:master Jan 14, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hlandau hlandau deleted the hlandauf:ecdsa-account-key-support branch Jan 14, 2016

@alex alex referenced this pull request Jan 16, 2016

Open

ECDSA account keys #2209

@Remonli Remonli referenced this pull request Feb 21, 2016

Closed

ECDSA account key support #76

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment