Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate publicsuffix dependency #1388
Conversation
This comment has been minimized.
This comment has been minimized.
|
I think you made an error along the way. This commit changes Godeps.json but does not include the changed code in |
jsha
added
the
needs-revision
label
Jan 20, 2016
mbwalas
added some commits
Jan 20, 2016
This comment has been minimized.
This comment has been minimized.
|
Yup, should be better now. |
jsha
added
r=jsha
r?
and removed
needs-revision
labels
Jan 21, 2016
This comment has been minimized.
This comment has been minimized.
|
Ugh, we just screwed you. Could you merge master in please? |
jmhodges
added
the
r=jmhodges
label
Jan 22, 2016
added a commit
that referenced
this pull request
Jan 22, 2016
jmhodges
merged commit e247285
into
letsencrypt:master
Jan 22, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
riking
removed
the
r?
label
Mar 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mbwalas commentedJan 20, 2016
Sha taken from https://github.com/letsencrypt/net/commits/master/publicsuffix
"Merge branch 'master' of https://go.googlesource.com/net"