New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publicsuffix dependency #1388

Merged
merged 5 commits into from Jan 22, 2016

Conversation

Projects
None yet
4 participants
@mbwalas
Copy link
Contributor

mbwalas commented Jan 20, 2016

@jsha

This comment has been minimized.

Copy link
Contributor

jsha commented Jan 20, 2016

I think you made an error along the way. This commit changes Godeps.json but does not include the changed code in net/publicsuffix. Did you follow the instructions in the README?

@jsha jsha added the needs-revision label Jan 20, 2016

@mbwalas

This comment has been minimized.

Copy link
Contributor Author

mbwalas commented Jan 21, 2016

Yup, should be better now.

@jsha jsha added r=jsha r? and removed needs-revision labels Jan 21, 2016

@jmhodges

This comment has been minimized.

Copy link
Contributor

jmhodges commented Jan 22, 2016

Ugh, we just screwed you. Could you merge master in please?

@jmhodges jmhodges added the r=jmhodges label Jan 22, 2016

jmhodges added a commit that referenced this pull request Jan 22, 2016

Merge pull request #1388 from mbwalas/godeps
Update publicsuffix dependency

@jmhodges jmhodges merged commit e247285 into letsencrypt:master Jan 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@riking riking removed the r? label Mar 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment