New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for underscores in subdomains #1437

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ajvb
Copy link

ajvb commented Jan 28, 2016

This is done by scanning the characters in the eTLD+1 separately from those in the subdomain.

I feel it is safe to put the _ in dnsLabelRegexp since if it was in the eTLD+1 it would get caught prior to that check.

Fixes #1225

Added support for underscores in subdomains
This is done by scanning the characters in the eTLD+1 separately from
those in the subdomain.

Fixes #1225
@rolandshoemaker

This comment has been minimized.

Copy link
Member

rolandshoemaker commented Jan 28, 2016

I'm closing this since we've internally decided #1225 is a Won't Fix, very sorry about that!

RFC 952 and 1123 outline that the safe hostname character set is [a-zA-Z0-9-] (with special rules about where hypens can appear). While certain DNS RR types (DomainKeys and SRV) are allowed to use underscores in record names these are not valid hostnames.

@ghost

This comment has been minimized.

Copy link

ghost commented Jan 9, 2018

I understand this won't be fixed. Please put me down as one of the people affected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment