New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OCSP-Responder double slash collapsing #2748

Merged
merged 4 commits into from May 10, 2017

Conversation

Projects
None yet
3 participants
@rolandshoemaker
Contributor

rolandshoemaker commented May 9, 2017

Uses a special mux for the OCSP Responder so that we stop collapsing double slashes in GET requests which cause a small number of requests to be considered malformed.

Fixes #2728.

@rolandshoemaker rolandshoemaker requested review from jsha and cpu May 9, 2017

Show outdated Hide outdated cmd/ocsp-responder/main.go Outdated
Show outdated Hide outdated cmd/ocsp-responder/main.go Outdated
Show outdated Hide outdated metrics/measured_http/http.go Outdated
Show outdated Hide outdated cmd/ocsp-responder/main.go Outdated
Show outdated Hide outdated cmd/ocsp-responder/main.go Outdated
@jsha

jsha approved these changes May 10, 2017

@cpu

cpu approved these changes May 10, 2017

Nice work, thanks @rolandshoemaker ! 🏞

@cpu cpu merged commit bd045b9 into master May 10, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 57.742%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment