Add ROCA weak key checking #3189
Conversation
|
FYI I just pushed a rewrite of the algorithm that halves the time it takes to check a key. |
|
LGTM if we pull in the updated lib. |
There was a problem hiding this comment.
I agree with @rolandshoemaker that we should update to the more performant version of this code before deploying.
|
@titanous looks like the full paper was just pushed to a preprint, haven't had a chance to look at it yet but any chance there will be further perf improvements based on their explanation of the fingerprinting process? |
|
Based on my understanding of the fingerprint, I don't believe that there are obvious substantial improvements to the current algorithm, though someone with a better math/perf background may be able to put something better together. The current 1μs for a good key and 18μs for a weak key on my i7-4850HQ (a 2013 2.3GHz laptop CPU) seems good enough. |
|
Yep, that's plenty good enough, thanks! |
Fixes #3183.
Thanks to @titanous for the library!