Fixup staticcheck and stylecheck, and violations thereof #5897
Conversation
| @@ -185,7 +185,7 @@ func (va *ValidationAuthorityImpl) validateTLSALPN01(ctx context.Context, identi | |||
| return validationRecords, problem | |||
| } | |||
|
|
|||
| if !cs.NegotiatedProtocolIsMutual || cs.NegotiatedProtocol != ACMETLS1Protocol { | |||
| if cs.NegotiatedProtocol != ACMETLS1Protocol { | |||
There was a problem hiding this comment.
Reference for anyone checking this diff: https://pkg.go.dev/crypto/tls#ConnectionState
// NegotiatedProtocolIsMutual used to indicate a mutual NPN negotiation.
//
// Deprecated: this value is always true.
NegotiatedProtocolIsMutual bool
| @@ -166,7 +166,7 @@ func (ci *clientInterceptor) intercept( | |||
| defer cancel() | |||
| // Disable fail-fast so RPCs will retry until deadline, even if all backends | |||
| // are down. | |||
| opts = append(opts, grpc.FailFast(false)) | |||
| opts = append(opts, grpc.WaitForReady(true)) | |||
There was a problem hiding this comment.
Reference:
https://pkg.go.dev/google.golang.org/grpc#FailFast
FailFast is the opposite of WaitForReady.
Deprecated: use WaitForReady.
https://pkg.go.dev/google.golang.org/grpc#WaitForReady
WaitForReady configures the action to take when an RPC is attempted on broken connections or unreachable servers. If waitForReady is false and the connection is in the TRANSIENT_FAILURE state, the RPC will fail immediately. Otherwise, the RPC client will block the call until a connection is available (or the call is canceled or times out) and will retry the call if it fails due to a transient error. gRPC will not retry if data was written to the wire unless the server indicates it did not process the data. Please refer to https://github.com/grpc/grpc/blob/master/doc/wait-for-ready.md.
By default, RPCs don't "wait for ready".
| } | ||
| } | ||
|
|
||
| unwrappedErr := status.Convert(err).Message() |
There was a problem hiding this comment.
Reference: https://pkg.go.dev/google.golang.org/grpc#ErrorDesc
ErrorDesc returns the error description of err if it was produced by the rpc system. Otherwise, it returns err.Error() or empty string when err is nil.
Deprecated: use status.Convert and Message method instead.
|
I actually plan to add a little bit more to this -- these are two other checks (gosimple and unused) that staticcheck go broken out into. I have a PR to add them but I'd like to land #5898 first so that I don't have to update wfe1 code to pass the checks :) If you're reviewing this one, go review that one first! |
|
Okay, I've got the additional lint checks re-added here. Please take a look! |
Add
stylecheckto our list of lints, since it got separated out fromstaticcheck. Fix the way we configure both to be clearer and notrely on regexes.
Additionally fix a number of easy-to-change
staticcheckandstylecheckviolations, allowing us to reduce our number of ignoredchecks.
Part of #5681