Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add Korean Translation (First PR) #595

Open
wants to merge 18 commits into
base: master
from

Conversation

@henrychoi7
Copy link

commented Aug 9, 2019

Hello, my name is Handong Choi.

I contacted Jenessa from Let's Encrypt last year and I would like to add some of our translated files. Sorry for the delay. We still have to translate more updated files and our current goal is to complete before September this year. SecurityPlus (a non-profit security community in Korea) will finish this work.

WIP files:

  • /content/ko/about.md
  • /content/ko/certificates.md
  • /content/ko/contact.md
  • /content/ko/donate.html
  • /content/ko/getinvolved.md
  • /content/ko/getting-started.md
  • /content/ko/how-it-works.md
  • /content/ko/nondiscrimination.md
  • /content/ko/privacy.md
  • /content/ko/stats-dashboard.md
  • /content/ko/thankyou.md
  • /content/ko/trademarks.md
  • /content/ko/upcoming-features.md
  • /content/ko/docs/_index.md
  • /content/ko/docs/allow-port-80.md
  • /content/ko/docs/caa.md
  • /content/ko/docs/cert-compat.md
  • /content/ko/docs/certificates-for-localhost.md
  • /content/ko/docs/challenge-types.md
  • /content/ko/docs/client-options.md
  • /content/ko/docs/ct-logs.html
  • /content/ko/docs/expiration-emails.md
  • /content/ko/docs/glossary.md
  • /content/ko/docs/staging-environment.md

Please review this work. 馃槃
Thank you!

henrychoi7 added some commits Aug 15, 2018

Added some translations
1. posts from 2016.3 to 2016.10

2. about, become-a-sponser, contact, faq, donate, getinvolved, isrg

3. jobs, repository, sponsors, stats
Added post translations
1. posts from 2015.09 to 2016.03

2. posts from 2016.10 to 2017.12

Signed-off-by: Henry Choi <wschd770@gmail.com>
Added post translations from 2015.06 to 2015.08
Signed-off-by: Henry Choi <wschd770@gmail.com>
Updated changes to translation contents
Signed-off-by: Henry Choi <wschd770@gmail.com>
Added some translations
1. posts from 2016.3 to 2016.10

2. about, become-a-sponser, contact, faq, donate, getinvolved, isrg

3. jobs, repository, sponsors, stats
Added post translations
1. posts from 2015.09 to 2016.03

2. posts from 2016.10 to 2017.12

Signed-off-by: Henry Choi <wschd770@gmail.com>
Added post translations from 2015.06 to 2015.08
Signed-off-by: Henry Choi <wschd770@gmail.com>
Updated changes to translation contents
Signed-off-by: Henry Choi <wschd770@gmail.com>
Renamed folder /content/kr to /content/ko and
updated translation files.

Signed-off-by: Henry Choi <wschd770@gmail.com>
Updated ko.toml and added single.html
Signed-off-by: Henry Choi <wschd770@gmail.com>
Modified config.toml (section for Korean)
Signed-off-by: Henry Choi <wschd770@gmail.com>
Merge branch 'korean' of https://github.com/henrychoi7/website into k鈥
鈥rean

Signed-off-by: Henry Choi <wschd770@gmail.com>
Removed /content/ko/base-l10n and i18n.md
Signed-off-by: Henry Choi <wschd770@gmail.com>
Removed aliases from the header of each file.
Signed-off-by: Henry Choi <wschd770@gmail.com>
Renamed howitworks.md to how-it-works.md
Signed-off-by: Henry Choi <wschd770@gmail.com>

@henrychoi7 henrychoi7 changed the title Adding Korean Translation (First PR) Add Korean Translation (First PR) Aug 9, 2019

@tdelmas tdelmas changed the title Add Korean Translation (First PR) [WIP] Add Korean Translation (First PR) Aug 11, 2019

@tdelmas

This comment has been minimized.

Copy link
Collaborator

commented Aug 11, 2019

As this PR is not ready to be merged I've add the WIP in the title.

Some files are in English, do you want this PR to be merged before they are translated? If yes, please replace the copy of the English files by the corresponding file of https://github.com/letsencrypt/website/tree/master/content/base-l10n (an almost empty file with untranslated: 1)

When you think this PR is ready to be merged (even if not all files are translated) please remove the WIP from the title.

@henrychoi7

This comment has been minimized.

Copy link
Author

commented Aug 11, 2019

Thank you for the review.

I think we should merge this PR after our team translates the whole work into Korean. I鈥檒l update further commits later and remove the WIP tag when we are ready! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.