Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser support! #10

Closed
mcollina opened this issue May 1, 2013 · 6 comments
Closed

Browser support! #10

mcollina opened this issue May 1, 2013 · 6 comments
Labels

Comments

@mcollina
Copy link
Collaborator

@mcollina mcollina commented May 1, 2013

LevelGraph should run as is in the Browser, on top of level-js.
Some browserify-fu is needed.

@refset
Copy link
Collaborator

@refset refset commented Jun 25, 2013

I just played around with this and AFAICT the blocker seems to be the absence of a browserify compatible streams2 implementation (though there could be one I've not found?).

The other option of course is to add v0.8 support & rewrite levelgraph to use through instead of streams2.

Can you tell me if that interpretation is right?

@mcollina
Copy link
Collaborator Author

@mcollina mcollina commented Jun 26, 2013

Your intepretation is totally right. Maybe some guys of the browserify crew can help giving directions. Maybe @juliangruber might help :).
I don't mind using through, btw.

You might also need a ES5 shim for some bad browser out there, as I am depending on forEach, map, filter and so on.

@juliangruber
Copy link
Contributor

@juliangruber juliangruber commented Jun 26, 2013

You can just use https://github.com/isaacs/readable-stream for streams2 support.

@mcollina
Copy link
Collaborator Author

@mcollina mcollina commented Jun 26, 2013

Then it should not be hard. Thanks @juliangruber!

@jez0990 do you fancy trying implementing browserify support and submitting a pull-request?

You should also switch the tests to https://npmjs.org/package/level-test.

@refset
Copy link
Collaborator

@refset refset commented Jun 29, 2013

A new branch is being created for this work: #22

@mcollina
Copy link
Collaborator Author

@mcollina mcollina commented Jul 1, 2013

Closed in favore of #23

@mcollina mcollina closed this Jul 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.