New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web push infrastructure #100

Merged
merged 22 commits into from Sep 10, 2018

Conversation

Projects
None yet
3 participants
@derrickreimer
Copy link
Member

derrickreimer commented Sep 5, 2018

WIP

@derrickreimer derrickreimer force-pushed the push-notifications branch from 225ec78 to 460eee9 Sep 6, 2018

@danbruder

This comment has been minimized.

Copy link

danbruder commented Sep 8, 2018

This repository continues to be a great example of good practices for elm/elixir. This pull request included!

@derrickreimer

This comment has been minimized.

Copy link
Member

derrickreimer commented Sep 8, 2018

Thanks @danbruder!

@alexgaribay

This comment has been minimized.

Copy link

alexgaribay commented on lib/level/web_push.ex in fd02743 Sep 10, 2018

I'd be careful of making this a module attribute. If you are going to do hot-code upgrades, you won't be able to change the adapter unless you do a complete app restart.

This comment has been minimized.

Copy link
Member

derrickreimer replied Sep 10, 2018

Ah interesting. Just lazy copied this from some example code 😄 might as well be a plain function.

This comment has been minimized.

derrickreimer added some commits Sep 10, 2018

@derrickreimer derrickreimer merged commit 53d5864 into master Sep 10, 2018

2 checks passed

ci/circleci: build_and_test_elixir Your tests passed on CircleCI!
Details
ci/circleci: build_and_test_elm Your tests passed on CircleCI!
Details

@derrickreimer derrickreimer deleted the push-notifications branch Sep 10, 2018

@derrickreimer

This comment has been minimized.

Copy link
Member

derrickreimer commented Sep 10, 2018

(Still more to do here, but this was getting large so I'm breaking it up into smaller tasks).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment