Post to groups #66
Merged
Post to groups #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devonestes
reviewed
May 21, 2018
lib/level/groups.ex
Outdated
| @@ -194,4 +210,19 @@ defmodule Level.Groups do | |||
| |> Ecto.Changeset.change(state: "CLOSED") | |||
| |> Repo.update() | |||
| end | |||
|
|
|||
| @doc false | |||
There was a problem hiding this comment.
One thing you might consider here is using the @impl true annotation (and in other places where you're implementing this behaviour). That's when you're specifying which functions are implementations of behaviour callbacks. You can read a bit more about @impl in the 1.5 release notes: https://elixir-lang.org/blog/2017/07/25/elixir-v1-5-0-released/ and in the issue around its addition to the language: elixir-lang/elixir#5734
devonestes
reviewed
May 21, 2018
| def create_post(space_user, params) do | ||
| @spec post_to_group(SpaceUser.t(), Group.t(), map()) :: post_to_group_result() | ||
| def post_to_group(space_user, group, params) do | ||
| Multi.new() |
There was a problem hiding this comment.
Nice use of Ecto.Multi! Looks like all this Elixir-ing is paying off.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64