Levi Cole levicole

Organizations

@codebrawl @websages
levicole commented on pull request TeriPastorino/blocmarks#5
@levicole

Well, I was thinking that we could do the same layout with an unordered list. The layout would be more responsive that way too. But after looking a…

levicole commented on pull request TeriPastorino/blocmarks#5
@levicole

I would start off with just using an unordered list here.

levicole commented on pull request TeriPastorino/blocmarks#4
@levicole

let's remove this.

levicole commented on pull request TeriPastorino/blocmarks#4
@levicole

You only need topic here, not [@topic, topic].

levicole commented on pull request TeriPastorino/blocmarks#4
@levicole

Let's remove this.

levicole commented on pull request TeriPastorino/blocmarks#4
@levicole

Do we want to link to the external URL here? If so, we only need bookmark.url, not [@topic, bookmark.url]

levicole commented on pull request TeriPastorino/blocmarks#4
@levicole

don't use bookmark.url here. bookmark.url is the path to the external url. We need to use just the bookmark object to create an internal URL for us…

levicole commented on pull request TeriPastorino/blocmarks#3
@levicole

Fix this formatting...should be indented

@levicole

Awesome! Go ahead and merge this into master!

@levicole
Welcome#index view still has dummy text
levicole created repository levicole/test
@levicole

This may be causing the issue...you already have this required once in the rails helper file.

@levicole

You can actually just add this to the development group below line 51. Either way, it still works!

@levicole

Looks good!

@levicole

This should actually be: @post = Post.find(params[:id]) That's how you ended up with that NoMethodError earlier. You can change that back to @post.…

levicole commented on pull request TeriPastorino/Blocitoff#4
@levicole

Don't forget that we are already looping through all the items in users/show, so you don't need to loop through them here. The link can just go rig…

levicole commented on pull request TeriPastorino/Blocitoff#4
@levicole

This will work, however, is it being associated with the user that created it? How might we do something like that using the built in methods the h…

levicole commented on pull request TeriPastorino/Blocitoff#4
@levicole

Same for this one

levicole commented on pull request TeriPastorino/Blocitoff#4
@levicole

We should delete this view. We don't need it.

levicole commented on pull request TeriPastorino/Blocitoff#4
@levicole

Since the user doesn't have lists, what should this be? How would we get a list of all the users items?

levicole commented on pull request TeriPastorino/Blocitoff#4
@levicole

I think we will want to redirect to the users show page here.

levicole commented on pull request TeriPastorino/Blocitoff#3
@levicole

I think we are good to go on this one! :+1:

levicole commented on pull request TeriPastorino/Blocitoff#3
@levicole

Also, we can just keep track of all the things we want to refactor and then have a refactoring session next week if you want! :)

levicole commented on pull request TeriPastorino/Blocitoff#3
@levicole

So, I was supposed to get you this: https://github.com/plataformatec/devise/wiki/How-To:-Test-with-Capybara This is how you log in without having t…

levicole commented on pull request TeriPastorino/Blocitoff#3
@levicole

I'm not sure what's going on here, but I have a feeling making this file was an accident?

@levicole

:+1:

@levicole

Teri, this is awesome. I didn't even think about testing this functionality!

@levicole

Let can't be inside the "it" block.

levicole commented on pull request TeriPastorino/Blocitoff#2
@levicole

This is looking good so far! We can fill out the pending specs today in our meeting.

levicole commented on pull request TeriPastorino/Blocitoff#2
@levicole

I think you are right. Let's set up database cleaner and factory girl today!