New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isoforms - partially undefined order of reported modified peptides #15
Comments
Thanks for reporting. I have reproduced the issue and will shortly look into ensuring a fixed order of output. |
@lutzfischer I got rid of sets and also sorted the |
Hi,
|
Ah, thanks for the catch! Indeed, I broke the fixed modifications with my change. They should be fixed now (haha). |
Hopefully this is resolved now, please report any problems with new |
yep, works fine now 👍 Thank you! |
Hi,
We I noticed a problem (at least for us) in how
isoforms
reports modified peptides. If there are two or more modifications defined that have the same/overlapping specificities, then the order in which these get applied to any given residue is undefined.E.g. given the peptide
XXXKXXXX
and two variable modification,a
andb
, that could happen onK
the isoform-function will sometimes yieldsXXXaKXXXX
,XXXbKXXXX
and sometimesXXXbKXXXX
,XXXaKXXXX
(only differs when the python interpreter is restarted in between - just running it twice directly one after the other yields the same order) . On itself this is not a big problem - but we have to cap the total number of reported modified peptides. And having a non defined order then leads to different subsets of modified peptides being used.I suspect the problem comes from the use of sets for encoding the possible modifications on each residue of a peptide.
The text was updated successfully, but these errors were encountered: