Only allow useful @param and @return annotations #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disallows the use of individual
@param
and@return
annotations when PHP type declarations already provide sufficient information.Instead of requiring that all parameters and the return type are documented:
...this allows (and even enforces) that only "useful" annotations are used:
This way, we can keep our codebase "clean" with only the docblock annotations we really need.
The violations can be automatically fixed by CodeSniffer using the
vendor/bin/phpcbf
command, but that may leave behind some trailing blank lines in docblocks, so some manual care is recommended.