New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split pane resizing moving Atom window #35

Open
AlecRust opened this Issue Nov 29, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@AlecRust

AlecRust commented Nov 29, 2017

Seems some parts of Atom's split pane bar are being treated as a window move handle:

screenshot

@lexicalunit lexicalunit self-assigned this Nov 29, 2017

@lexicalunit lexicalunit added the bug label Nov 29, 2017

@lexicalunit

This comment has been minimized.

Show comment
Hide comment
@lexicalunit

lexicalunit Dec 6, 2017

Owner

Interesting, this seems to be partly affected by UI Theme. I can't recreate the issue with native-ui, but I can with atom-dark.

Owner

lexicalunit commented Dec 6, 2017

Interesting, this seems to be partly affected by UI Theme. I can't recreate the issue with native-ui, but I can with atom-dark.

@lexicalunit

This comment has been minimized.

Show comment
Hide comment
@lexicalunit

lexicalunit Dec 6, 2017

Owner

Hrm, it also seems to be the case that my LESS code I wrote to specifically handle this case is not being fully honored.

The element in question is an atom-pane-resize-handle.vertical:before which has the attribute -webkit-app-region: no-drag. However somehow when that element overlays on top of an element that does have drag enabled, we get this issue.

So if you click just above the resize handle, which is overlaid on top of the text editor area, the resize works. But if you click just below the resize handle, to the right of the last tab, that area is overlaid on top of a tab bar. And tab bar elements have window drag enabled.

🤔

Owner

lexicalunit commented Dec 6, 2017

Hrm, it also seems to be the case that my LESS code I wrote to specifically handle this case is not being fully honored.

The element in question is an atom-pane-resize-handle.vertical:before which has the attribute -webkit-app-region: no-drag. However somehow when that element overlays on top of an element that does have drag enabled, we get this issue.

So if you click just above the resize handle, which is overlaid on top of the text editor area, the resize works. But if you click just below the resize handle, to the right of the last tab, that area is overlaid on top of a tab bar. And tab bar elements have window drag enabled.

🤔

@lexicalunit

This comment has been minimized.

Show comment
Hide comment
@lexicalunit

lexicalunit Dec 6, 2017

Owner

@AlecRust for now you can disable dragging on split pane tab bars using this in your Atom Stylesheet:

atom-pane-resize-handle + atom-pane {
  .tab-bar {
    -webkit-app-region: no-drag !important;
  }
}

That completely disables window dragging for any tab-bar element next to a resize handle. That's less than ideal. I'd much rather be able to support window dragging and have the resize handle work as intended but there seems to be some kind of bug preventing that from working correctly. Maybe something to do with Electron? Not sure :(

Owner

lexicalunit commented Dec 6, 2017

@AlecRust for now you can disable dragging on split pane tab bars using this in your Atom Stylesheet:

atom-pane-resize-handle + atom-pane {
  .tab-bar {
    -webkit-app-region: no-drag !important;
  }
}

That completely disables window dragging for any tab-bar element next to a resize handle. That's less than ideal. I'd much rather be able to support window dragging and have the resize handle work as intended but there seems to be some kind of bug preventing that from working correctly. Maybe something to do with Electron? Not sure :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment