Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Mark the exik_jwt_authentication.encoder.default service as autowire default for JWTEncoderInterface #256
First, congrats on 2.0! I'm looking forward to checkout out all the changes!
On KnpU, since we use this bundle, I just had one user mention a small change in 2.0 that I think we can make smoother. Specifically, we use autowiring on a service that has
Could we mark the
@weaverryan Really, thank you very much for the help you given on this major version.
About the autowiring types, it's indeed something good to have that I totally missed
I have to remind you that this bundle now has a built-in Guard authenticator, greatly inspired from the one of your KnpUniversity lesson and presentation (I'm pretty sure it is the very same that the DIC was not able to autowire :))
Feedbacks from you and your collaborators will be greatly appreciated.
Closing as fixed in #257. Thank you!
Wow, that was so fast! And I already replied to the user (who just posted the comment this morning!). You rock :).
I have an issue internally to pull down 2.0.1 with our tutorial and make sure things are smooth - that'll be my chance to really test out the new version. I'm also excited to look at the authenticator - I will probably at least add a note so that users know that this is an option (versus building their own, which is a nice exercise, but not necessarily the best actual solution).