#4 Settings does not exist #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lexxpavlov
requested changes
Mar 31, 2017
Service/Settings.php
Outdated
| return $value->getValue(); | ||
| } | ||
|
|
||
| return ""; |
Service/Settings.php
Outdated
| @@ -98,19 +107,24 @@ private function loadGroup($name) | |||
| * | |||
| * @param string $name Setting name or group name (if $subname is set) | |||
| * @param string|null $subname Setting name (use with $name as group name) | |||
| * @param null $default The default value if the setting key does not exist | |||
There was a problem hiding this comment.
Type of $default must be mixed|null
Service/Settings.php
Outdated
| @@ -48,7 +52,12 @@ private function getCacheGroupKey($name) | |||
|
|
|||
| private function fetch($name) | |||
| { | |||
| return $this->repository->findOneBy(array('name' => $name))->getValue(); | |||
| $value = $this->repository->findOneBy(array('name' => $name)); | |||
There was a problem hiding this comment.
Variable name must be $setting
|
I pushed changes. |
lexxpavlov
approved these changes
Mar 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.