pillar: hardware: Read SoC serial number from sysfs #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoC platform driver exports SoC unique serial number through sysfs, which usually can be read in /sys/devices/soc0/serial_number. Pillar doesn't consider this resource to look at it for device's serial number. This commit does the following: - Adds /sys/devices/soc0/serial_number as a resource to look at it for device's serial number - Fixes checking of dmidecode result: Pillar uses primarily dmidecode to find device's serial number. If no serial number is found, dmidecode can return the "Not Specified" string, instead of null. If "" or "Not Specified" is returned, call getCPUSerial() to look into auxiliary resources. Signed-off-by: Renê de Souza Pinto <rene@renesp.com.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SoC platform driver exports SoC unique serial number through sysfs, which usually can be read in /sys/devices/soc0/serial_number. Pillar doesn't consider this resource to look at it for device's serial number.
This PR does the following:
Adds /sys/devices/soc0/serial_number as a resource to look at it for device's serial number
Fixes checking of dmidecode result: Pillar uses primarily dmidecode to find device's serial number. If no serial number is found, dmidecode can return the "Not Specified" string, instead of null. If "" or "Not Specified" is returned, call getCPUSerial() to look into auxiliary resources.
PS1: This issue was observed in i.MX8MP platform. PR was tested successfully using changes from PR #3022
PS2: Yetus is failing because of ioutils deprecated errors (fixed in #3021). This PR uses os.ReadFile() already.
Signed-off-by: Renê de Souza Pinto rene@renesp.com.br