Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User facing utility functions such as info_print should also have lf_ prefix #1124

Closed
housengw opened this issue Apr 28, 2022 · 4 comments · Fixed by #1127
Closed

User facing utility functions such as info_print should also have lf_ prefix #1124

housengw opened this issue Apr 28, 2022 · 4 comments · Fixed by #1127
Labels
c Related to C target

Comments

@housengw
Copy link
Contributor

As discussed here: lf-lang/lf-lang.github.io#47 (comment)
There are some user facing util functions that do not yet have an lf_ prefix

@housengw housengw added the c Related to C target label Apr 28, 2022
@lhstrh
Copy link
Member

lhstrh commented Apr 28, 2022

Should the lf_*_print prototypes also be listed (or included) in ctarget.h`?

@housengw
Copy link
Contributor Author

i think so.

@edwardalee
Copy link
Collaborator

I suggest renaming info_print to lf_print, rather than just adding a prefix. The others could just get a prefix.

@lhstrh
Copy link
Member

lhstrh commented Apr 29, 2022

I like that idea. If we do this I would go for lf_print_error etc (switch order of error and print).

@housengw housengw linked a pull request Apr 30, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c Related to C target
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants