Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a -v / --version flag to lfc #927

Closed
lhstrh opened this issue Feb 2, 2022 · 1 comment · Fixed by #979
Closed

Add a -v / --version flag to lfc #927

lhstrh opened this issue Feb 2, 2022 · 1 comment · Fixed by #979
Labels
enhancement Enhancement of existing feature good first issue Good for newcomers lfc
Milestone

Comments

@lhstrh
Copy link
Member

lhstrh commented Feb 2, 2022

Where should it read the version number from?

@lhstrh lhstrh changed the title Add a -v / --version flag to lfc Add a -v / --version flag to lfc Feb 2, 2022
@cmnrd cmnrd added the lfc label Feb 4, 2022
@cmnrd cmnrd added this to the 0.1.0 milestone Feb 4, 2022
@cmnrd cmnrd added enhancement Enhancement of existing feature good first issue Good for newcomers labels Feb 4, 2022
@cmnrd
Copy link
Collaborator

cmnrd commented Feb 4, 2022

We could have a simple file version.txt in org.lflang.lfc. This should be easy to update by a script. Alternatively, we could define a constant in Main, which would be slightly more difficult to update.

-v is commonly used for verbose and I would reserve it for this use. It's probably fin to just have the long form --version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement of existing feature good first issue Good for newcomers lfc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants