Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java configuration bumped to version 17 #1094

Merged
merged 27 commits into from
Apr 24, 2022
Merged

Java configuration bumped to version 17 #1094

merged 27 commits into from
Apr 24, 2022

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Apr 12, 2022

This PR brings the minimum Java requirement from 11 to 17. This has several advantages:

  • better syntax for code generators written in Java (string templates)
  • compatibility with Apple Silicon
  • long-term support (17 is the latest LTS release)

In addition, this PR fixes #1079.

@lhstrh lhstrh marked this pull request as draft April 12, 2022 07:22
@lhstrh lhstrh marked this pull request as ready for review April 22, 2022 22:15
Copy link
Contributor

@housengw housengw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can use this PR as a reference of all the JavaSE-* version that need to be updated to bump the java version. Thank you for doing this!

@lhstrh
Copy link
Member Author

lhstrh commented Apr 22, 2022

LGTM! We can use this PR as a reference of all the JavaSE-* version that need to be updated to bump the java version. Thank you for doing this!

Yes, we could. That said, I think the intention here is not to change this until another LTS version appears.

@lhstrh lhstrh changed the title Java 17 Java configuration bumped to version 17 Apr 23, 2022
@lhstrh lhstrh merged commit cccd3d8 into master Apr 24, 2022
@cmnrd cmnrd deleted the java-17 branch March 10, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove logic for handling examples from testing framework
3 participants