New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use run/7 to skip unmodified .lfe files #5

Merged
merged 6 commits into from Feb 11, 2016

Conversation

Projects
None yet
2 participants
@yurrriq
Member

yurrriq commented Feb 11, 2016

This needs another set of eyes, but is working well for me locally.
I started a bigger refactor, but after a while I stopped and rolled back to this fairly minimal diff.
Since this is usually run as a compile post-hook, there's a lot that the erlc compiler has to do that we don't.

Show outdated Hide outdated src/lr3_comp.erl
CompileResults = lfe_comp:file(Source, Opts),
compile(Source, Target, Config) ->
rebar_api:console(" ~~~~> \tCompiling ~s ...",
[lr3_comp_util:relative(Source)]),

This comment has been minimized.

@yurrriq

yurrriq Feb 11, 2016

Member

Wanna fold these inline? I mostly introduced the variables to aid in my understanding of the run/7 semantics.

@yurrriq

yurrriq Feb 11, 2016

Member

Wanna fold these inline? I mostly introduced the variables to aid in my understanding of the run/7 semantics.

This comment has been minimized.

@yurrriq

yurrriq Feb 11, 2016

Member

Did it in e4cb158.

@yurrriq

yurrriq Feb 11, 2016

Member

Did it in e4cb158.

Move config/2 and ensure_dir/1 to lr3_util_comp
... and inline SourceExt and TargetExt in run/7 call in compile_dir/4.

yurrriq added a commit to quasiquoting/lfe-compile that referenced this pull request Feb 11, 2016

Update README.md
- Remove legacy ".*" from dependency example
- Fix typo in provider_hooks example: s/pre/post/

Depends on #5

https://www.rebar3.org/docs/dependencies#declaring-dependencies

@yurrriq yurrriq referenced this pull request Feb 11, 2016

Merged

Update README.md #6

@oubiwann

This comment has been minimized.

Show comment
Hide comment
@oubiwann

oubiwann Feb 11, 2016

Member

Thanks, man!

Member

oubiwann commented Feb 11, 2016

Thanks, man!

oubiwann added a commit that referenced this pull request Feb 11, 2016

Merge pull request #5 from quasiquoting/develop
Use run/7 to skip unmodified .lfe files

@oubiwann oubiwann merged commit 84c54be into lfe-rebar3:master Feb 11, 2016

@yurrriq

This comment has been minimized.

Show comment
Hide comment
@yurrriq

yurrriq Feb 11, 2016

Member

My pleasure. Thanks for merging! 🎉

Member

yurrriq commented Feb 11, 2016

My pleasure. Thanks for merging! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment