Lucas Mirelmann lgalfaso

  • Joined on

Organizations

@angular
@lgalfaso

Do you have any plans to add Angular2 support? Angular 2 is still under development, but once there is a clear path to do on-demand code loading …

@lgalfaso

While trying to reproduce this, I found and fixed another issue, but if you can create a scenario that shows the problem, then I would like to fix …

lgalfaso commented on pull request angular/angular.js#12226
@lgalfaso

@seaside98 run the script at the jsbin ~50 times and not even once the error show up. Is there some specific step that needs to happen for this err…

@lgalfaso

@nomve would it be possible that the locale is changed multiple times back-and-forward within the bootstrap?

@lgalfaso
  • @lgalfaso 6d25d49
    style(parameter): Remove unused parameter in one test
@lgalfaso
lgalfaso commented on pull request angular/angular.js#12709
@lgalfaso

Wondering if changing if (number.toString().indexOf('.') >= 0) { for if (number.toString().indexOf('.') >= 0 && number.toString().split('.')[1].length

lgalfaso commented on pull request angular/angular.js#12709
@lgalfaso

It looks like this does not solve the problem entirely. eg. expect(formatNumber(999999999999999.9, pattern, ',', '.', 7)) .toBe('999,999,999,999,99…

@lgalfaso
  • @lgalfaso 67afd9d
    docs(CHANGELOG): Add breaking change notice for issue 12506
lgalfaso closed pull request angular/angular.js#12705
@lgalfaso
docs(CHANGELOG): Add breaking change notice for issue 12506
@lgalfaso
  • @lgalfaso 67afd9d
    docs(CHANGELOG): Add breaking change notice for issue 12506
@lgalfaso
lgalfaso commented on pull request angular/angular.js#12705
@lgalfaso

hmm... we didn't realize that this would break tests when we merged the original PR. Keep in mind that this is only for test that create a promise…

@lgalfaso

@nomve this looks like another issue, but maybe related. Would it be possible to know the exact version that you are using? Also, can you check if …

@lgalfaso
  • @lgalfaso 7d2c6ee
    fix($parse): `assign` returns the new value
lgalfaso closed pull request angular/angular.js#12708
@lgalfaso
fix($parse): `assign` returns the new value
@lgalfaso
Angular 1.4.4, $parse, assign function does not return the value set
@lgalfaso
  • @lgalfaso 2e6bbae
    fix($parse): `assign` returns the new value
lgalfaso commented on issue angular/angular.js#12698
@lgalfaso

@marcelboelen ok, but I think you are talking about the YYYY symbol in the table (that is not implemented and would be a nice addition).

lgalfaso commented on issue angular/angular.js#12506
@lgalfaso

@plestik I do not think this issue should be reopened, at least not in the current state as ngRepeat is working as expected. I would be ok in openi…

lgalfaso commented on issue angular/angular.js#12698
@lgalfaso

@marcelboelen I do not understand your assertion I'm missing the 'year week' symbol The symbol w is week of the year. The other assertion is clea…

@lgalfaso
  • @oddui 170cd96
    fix(docs): fix typo "Hasbang"
lgalfaso closed pull request angular/angular.js#12712
@lgalfaso
fix(docs): fix typo "Hasbang"
lgalfaso commented on pull request angular/angular.js#12598
@lgalfaso

Should this be Function.prototype.bind.apply?

lgalfaso commented on pull request lgalfaso/angular-dynamic-locale#72
@lgalfaso

Without a clear way to reproduce this, I have no real way of being 100% sure, but it looks like requirejs at some point executes https://github.com…

lgalfaso commented on pull request lgalfaso/angular-dynamic-locale#72
@lgalfaso

At #52, the project uses require.js, is this the case in your project? Are you using any other library that does dynamic code loading?

lgalfaso commented on pull request lgalfaso/angular-dynamic-locale#72
@lgalfaso

Thanks for the PR. Would it be possible to know how it is possible to trigger the bug that this fixes?

@lgalfaso
  • @lgalfaso 109cf50
    fix($parse): `assign` returns the new value
lgalfaso opened pull request angular/angular.js#12708
@lgalfaso
fix($parse): `assign` returns the new value
1 commit with 2 additions and 1 deletion