Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase performance #15

Merged
merged 3 commits into from Aug 8, 2019

Conversation

@lgalke
Copy link
Owner

commented Aug 8, 2019

  • many minor improvments to avoid unnecessary copying of data
  • CategoricalCondition had an attribute vocab_size already to limit number of distinct authors. Now it can also deal with a fraction as argument, s.th. vocab_size=0.01 will select the top 1% of authors.
@mapo89
Copy link
Collaborator

left a comment

Sounds all good thanks. I will test the changes and see how much faster VAE will be.

@mapo89 mapo89 merged commit a9a0709 into generic-condition Aug 8, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.