Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also include C shared libraries build? #69

Open
marianopeck opened this issue Jul 15, 2019 · 4 comments
Open

Also include C shared libraries build? #69

marianopeck opened this issue Jul 15, 2019 · 4 comments

Comments

@marianopeck
Copy link

@marianopeck marianopeck commented Jul 15, 2019

Hi!

Did you ever consider to add support to not only build the Python wheel but also a shared library? As far as I understand, everything is exactly the same except the line:

//tensorflow/tools/pip_package:build_pip_package

which should be:

//tensorflow/tools/lib_package:libtensorflow

This would help us all other language bindings (Go, Rust, etc) to have the shared library available...which is currently anywhere and you have to compile everything from scratch.... I am not pretending for all the available configs in configs but at least the one you do publish a Python wheel: https://github.com/lhelontra/tensorflow-on-arm/releases/tag/v1.14.0

Thoughts?

@marianopeck

This comment has been minimized.

Copy link
Author

@marianopeck marianopeck commented Jul 17, 2019

Hi, as I found no binary available, I had to manage myself.
I finally took the time to write down everything I found during my attempt to get TensorFlow C library compiled for Raspberry Pi. In that tutorial, I point back to this issue in case you eventually start building shared libraries too.
Best regards,

@lhelontra

This comment has been minimized.

Copy link
Owner

@lhelontra lhelontra commented Jul 18, 2019

Hi @marianopeck
I distribute only whl files, if u want library and headers, append //tensorflow/tools/lib_package:libtensorflow in bazel options.

@marianopeck

This comment has been minimized.

Copy link
Author

@marianopeck marianopeck commented Jul 18, 2019

Hi @lhelontra
OK, what a pity :(
If I fork the project and submit a PR with the necessary changes in rpi.conf (almost a one-liner) as well as confirming it works, would you be willing to merge and distribute it?

Thanks!

@JinmingYang5

This comment has been minimized.

Copy link

@JinmingYang5 JinmingYang5 commented Feb 5, 2020

Hi @lhelontra Could you share some of successfully built tensorflow c api packages for arm on github ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.