Support for pre-determined batch sizes in DynamicBucketingSampler #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one can precompute the maximum possible batch sizes for every bucket, they can be provided to the sampler using this mechanism. That's an alternative to the auto-batch-size sampling mechanism using
max_durationandquadratic_durationwhich can guarantee close-to-maximum GPU memory utilization in training without running into OOM during training.An example of how to determine maximum batch sizes for a given model+optimizer+hardware configuration is available in NVIDIA/NeMo#9763