Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-simple expressions in matching score are re-evaluated for each individual #128

gdementen opened this issue Jun 24, 2014 · 1 comment


Copy link

Non-simple expressions (EvaluableExpression children) are re-evaluated on all of set2 for each individual in set1. For example, links in the score expression (as in tests / functional / simulation.yml) are recomputed over and over again. Needless to say, this slows things down tremendously. We should detect them and pre-evaluate them. Or... just wait for caching and "common subexpression elimination" (#98) which should fix this issue nicely.

@gdementen gdementen self-assigned this Jun 24, 2014
Copy link
Member Author

Note that many non-simple expressions cannot be pre-computed/cached. Those involving random numbers (see #343), or functions having both "set1" and "other." variables in their arguments (eg. trunc(age - other.age)), and possibly others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

1 participant