Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upNon-simple expressions in matching score are re-evaluated for each individual #128
Comments
gdementen
added
bug
labels
Jun 24, 2014
gdementen
self-assigned this
Jun 24, 2014
gdementen
added
internals
and removed
internals
labels
Sep 11, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gdementen commentedJun 24, 2014
Non-simple expressions (EvaluableExpression children) are re-evaluated on all of set2 for each individual in set1. For example, links in the score expression (as in tests / functional / simulation.yml) are recomputed over and over again. Needless to say, this slows things down tremendously. We should detect them and pre-evaluate them. Or... just wait for caching and "common subexpression elimination" (#98) which should fix this issue nicely.