New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cont_regr with both filter and mult break #153

Closed
gdementen opened this Issue Feb 9, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@gdementen
Member

gdementen commented Feb 9, 2015

- value: cont_regr(2.4 + 0.22 * age, mult=0.5, filter=age > 10)

results in:
ERROR: DFC // dynamicfunctioncall(normal(0, 1).dtype, None)
(or with earlier versions):
ERROR: normal(loc=0, scale=1).dtype(<context.EntityContext object at 0x066D07D0>)

@gdementen gdementen added the bug label Feb 9, 2015

@gdementen gdementen self-assigned this Feb 9, 2015

@gdementen gdementen added this to the 0.10 milestone Feb 9, 2015

@gdementen

This comment has been minimized.

Show comment
Hide comment
@gdementen

gdementen Feb 11, 2015

Member

For a test case, see: https://gist.github.com/gdementen/e629dce747efab334b69

In 0.9, the following workaround works:

- value: cont_regr(2.4 + 0.22 * age + 0.5 * normal(), filter=age > 10)

However, this workaround apparently does not work in 0.8.1.

Member

gdementen commented Feb 11, 2015

For a test case, see: https://gist.github.com/gdementen/e629dce747efab334b69

In 0.9, the following workaround works:

- value: cont_regr(2.4 + 0.22 * age + 0.5 * normal(), filter=age > 10)

However, this workaround apparently does not work in 0.8.1.

@gdementen gdementen modified the milestones: 0.10, 0.9.1 Mar 20, 2015

gdementen added a commit that referenced this issue Mar 20, 2015

fixed random distribution dtypes
geometric, hypergeometric and zipf return integers
all others use always(float) instead of having no dtype method defined (doh!)
also made dtype a required argument to avoid such silly errors
added a test case for cont_regr with both mult and filter which initially exposed the problem (closes issue #153)

@gdementen gdementen closed this Mar 20, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment