Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add an extra ASTNode pass #41

Closed
gdementen opened this issue Feb 13, 2014 · 1 comment
Closed

add an extra ASTNode pass #41

gdementen opened this issue Feb 13, 2014 · 1 comment
Assignees
Milestone

Comments

@gdementen
Copy link
Member

@gdementen gdementen commented Feb 13, 2014

the goal is to "compile" expressions to another representation which:

  • has an uniform interface, so that it can be walked/traversed recursively without having to define a traverse method on most expression classes.
  • has not its eq method overloaded so that I can use "expr in d" (dict.contains(k) calls k.eq) so that I can store expressions in a dict to check whether they occur more than once

Questions:

  • use ASTNode class in numexpr as is?
  • would an uniform interface make things cleaner for current functionalities (mainly as_string, collect_variables and simplify)?
@ghost ghost assigned gdementen Feb 13, 2014
@gdementen gdementen added this to the 0.9 milestone Feb 25, 2014
@gdementen
Copy link
Member Author

@gdementen gdementen commented Nov 18, 2014

done (devel branch is merged)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant