Do not fail when bcolz import fails

[benjello]

No description provided.

[landscape-bot]

Code quality remained the same when pulling e74381f on benjello:master into 02b807d on liam2:master.

[gdementen]

If you want to make bcolz optional (which is fine with me given its very limited usage), please include an explicit exception if its functionality (interpolate in this case) is used anyway.

2 other places need to be adapted too:

• PrintVersionsAction in main.py
  https://github.com/benjello/liam2/blob/master/src/main.py#L171
• https://github.com/liam2/liam2/blob/master/INSTALL

[benjello]

Just starting the conversation to test your mood ;-)
More commits to come. Please do not hesitate to be straightforward in your comments, it actually helps me understand your priorities.

[benjello]

Could you write the sentence you would like to appear in https://github.com/liam2/liam2/blob/master/INSTALL ?

[landscape-bot]

Code quality remained the same when pulling cf9ff0e on benjello:master into 02b807d on liam2:master.

[gdementen]

just move it to the optional dependencies paragraph with something like:

to import data with interpolation/data with missing data points (eg several time series with different dates for the same individual):

[gdementen]

plz move this below the "optional deps" comment

[landscape-bot]

Code quality remained the same when pulling 92aefda on benjello:master into 02b807d on liam2:master.

[gdementen]

plz use N/A when missing, and use the same template (bc_version = ...) than for other optional deps (it is not especially better, but lets be consistent)

[gdementen]

Thanks for this! I never bothered to look up the exact syntax :)

[benjello]

Not tested though !

[gdementen]

Please test then ;-)

On Wed, May 13, 2015 at 10:51 AM, Mahdi Ben Jelloul <
notifications@github.com> wrote:

In src/setup.py
#161 (comment):

@@ -143,5 +143,12 @@ def vitables_data_files():
ext_modules=ext_modules,
options={"build_ext": build_ext_options, "build_exe": build_exe_options},
executables=[Executable("main.py")],

•  requires=['numpy', 'numexpr', 'tables', 'bcolz'])
  

•  install_requires=['numpy', 'numexpr', 'tables'],
  

•  extra_requires=dict(
  

Not tested though !

Reply to this email directly or view it on GitHub
https://github.com/liam2/liam2/pull/161/files#r30212604.

[benjello]

I actually use another setup.py hacked to work on a linux machine so won't be able to test it for windows users (@AlexisEidelman ?). I do not plan to submit a complete overhaul of setup.py (with a travis CI config file etc) this early. My pint with this commit was to propagate upstream as soon as possible what could be propagated without to much hassle.
But i did checked the syntax though ;-)

[gdementen]

hmmm a quick google seem to suggest "extras_require" instead of "extra_requires"...

[benjello]

Sorry I will fix that

[landscape-bot]

Code quality remained the same when pulling 55edc2b on benjello:master into 02b807d on liam2:master.

[landscape-bot]

Code quality remained the same when pulling fd80452 on benjello:master into 02b807d on liam2:master.

[landscape-bot]

Code quality remained the same when pulling 1895ae8 on benjello:master into 02b807d on liam2:master.

[gdementen]

Looks good to me, thanks!