New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not fail when bcolz import fails #161

Merged
merged 6 commits into from May 13, 2015

Conversation

Projects
None yet
3 participants
@benjello
Contributor

benjello commented May 12, 2015

No description provided.

@landscape-bot

This comment has been minimized.

Show comment
Hide comment
@landscape-bot

landscape-bot May 12, 2015

Code Health
Code quality remained the same when pulling e74381f on benjello:master into 02b807d on liam2:master.

landscape-bot commented May 12, 2015

Code Health
Code quality remained the same when pulling e74381f on benjello:master into 02b807d on liam2:master.

@gdementen

This comment has been minimized.

Show comment
Hide comment
@gdementen

gdementen May 12, 2015

Member

If you want to make bcolz optional (which is fine with me given its very limited usage), please include an explicit exception if its functionality (interpolate in this case) is used anyway.

2 other places need to be adapted too:

Member

gdementen commented May 12, 2015

If you want to make bcolz optional (which is fine with me given its very limited usage), please include an explicit exception if its functionality (interpolate in this case) is used anyway.

2 other places need to be adapted too:

@benjello

This comment has been minimized.

Show comment
Hide comment
@benjello

benjello May 13, 2015

Contributor

Just starting the conversation to test your mood ;-)
More commits to come. Please do not hesitate to be straightforward in your comments, it actually helps me understand your priorities.

Contributor

benjello commented May 13, 2015

Just starting the conversation to test your mood ;-)
More commits to come. Please do not hesitate to be straightforward in your comments, it actually helps me understand your priorities.

@benjello

This comment has been minimized.

Show comment
Hide comment
@benjello

benjello May 13, 2015

Contributor

Could you write the sentence you would like to appear in https://github.com/liam2/liam2/blob/master/INSTALL ?

Contributor

benjello commented May 13, 2015

Could you write the sentence you would like to appear in https://github.com/liam2/liam2/blob/master/INSTALL ?

@landscape-bot

This comment has been minimized.

Show comment
Hide comment
@landscape-bot

landscape-bot May 13, 2015

Code Health
Code quality remained the same when pulling cf9ff0e on benjello:master into 02b807d on liam2:master.

landscape-bot commented May 13, 2015

Code Health
Code quality remained the same when pulling cf9ff0e on benjello:master into 02b807d on liam2:master.

@gdementen

This comment has been minimized.

Show comment
Hide comment
@gdementen

gdementen May 13, 2015

Member

just move it to the optional dependencies paragraph with something like:

to import data with interpolation/data with missing data points (eg several time series with different dates for the same individual):

Member

gdementen commented May 13, 2015

just move it to the optional dependencies paragraph with something like:

to import data with interpolation/data with missing data points (eg several time series with different dates for the same individual):

Show outdated Hide outdated src/main.py
@landscape-bot

This comment has been minimized.

Show comment
Hide comment
@landscape-bot

landscape-bot May 13, 2015

Code Health
Code quality remained the same when pulling 92aefda on benjello:master into 02b807d on liam2:master.

landscape-bot commented May 13, 2015

Code Health
Code quality remained the same when pulling 92aefda on benjello:master into 02b807d on liam2:master.

Show outdated Hide outdated src/main.py
Show outdated Hide outdated src/setup.py
@landscape-bot

This comment has been minimized.

Show comment
Hide comment
@landscape-bot

landscape-bot May 13, 2015

Code Health
Code quality remained the same when pulling 55edc2b on benjello:master into 02b807d on liam2:master.

landscape-bot commented May 13, 2015

Code Health
Code quality remained the same when pulling 55edc2b on benjello:master into 02b807d on liam2:master.

@landscape-bot

This comment has been minimized.

Show comment
Hide comment
@landscape-bot

landscape-bot May 13, 2015

Code Health
Code quality remained the same when pulling fd80452 on benjello:master into 02b807d on liam2:master.

landscape-bot commented May 13, 2015

Code Health
Code quality remained the same when pulling fd80452 on benjello:master into 02b807d on liam2:master.

@landscape-bot

This comment has been minimized.

Show comment
Hide comment
@landscape-bot

landscape-bot May 13, 2015

Code Health
Code quality remained the same when pulling 1895ae8 on benjello:master into 02b807d on liam2:master.

landscape-bot commented May 13, 2015

Code Health
Code quality remained the same when pulling 1895ae8 on benjello:master into 02b807d on liam2:master.

@gdementen

This comment has been minimized.

Show comment
Hide comment
@gdementen

gdementen May 13, 2015

Member

Looks good to me, thanks!

Member

gdementen commented May 13, 2015

Looks good to me, thanks!

gdementen added a commit that referenced this pull request May 13, 2015

Merge pull request #161 from benjello/master
Do not fail when bcolz import fails

@gdementen gdementen merged commit 449128f into liam2:master May 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment