{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":816485048,"defaultBranch":"master","name":"pytorch-lightning","ownerLogin":"liambsmith","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-06-17T21:18:35.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/3461091?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1718826622.0","currentOid":""},"activityList":{"items":[{"before":"f73dc834ea5c8cc4d81ddde353dedfabf89931cf","after":"ebd278877b65e8305526956e569991e9754bb226","ref":"refs/heads/master","pushedAt":"2024-06-20T17:46:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"liambsmith","name":null,"path":"/liambsmith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3461091?s=80&v=4"},"commit":{"message":"Merge branch 'Lightning-AI:master' into master","shortMessageHtmlLink":"Merge branch 'Lightning-AI:master' into master"}},{"before":"1bc6ea2250b96fb89985bb39f26e29aaf2b3514e","after":"f73dc834ea5c8cc4d81ddde353dedfabf89931cf","ref":"refs/heads/master","pushedAt":"2024-06-20T17:44:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pre-commit-ci[bot]","name":null,"path":"/apps/pre-commit-ci","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/68672?s=80&v=4"},"commit":{"message":"[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci","shortMessageHtmlLink":"[pre-commit.ci] auto fixes from pre-commit.com hooks"}},{"before":"056be5da460a628bcb3814ad74b348f5aec44853","after":"1bc6ea2250b96fb89985bb39f26e29aaf2b3514e","ref":"refs/heads/master","pushedAt":"2024-06-20T17:42:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"liambsmith","name":null,"path":"/liambsmith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3461091?s=80&v=4"},"commit":{"message":"Changed validation eval/train to just call model.train() and model.eval()\n\nChange to not overcomplicate the fix for fabric not working with the default \"on_validation_model_eval\" and \"on_validation_model_train\".","shortMessageHtmlLink":"Changed validation eval/train to just call model.train() and model.ev…"}},{"before":null,"after":"1e83a1bd32a29e1c8802d0593dbcd6e6b173a8d3","ref":"refs/heads/fabric_logging","pushedAt":"2024-06-19T19:50:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"liambsmith","name":null,"path":"/liambsmith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3461091?s=80&v=4"},"commit":{"message":"Check if CometLogger experiment is alive (#19915)\n\n\r\nCo-authored-by: Etay Livne <etay.livne@mobileye.com>","shortMessageHtmlLink":"Check if CometLogger experiment is alive (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322439737\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Lightning-AI/pytorch-lightning/issues/19915\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Lightning-AI/pytorch-lightning/pull/19915/hovercard\" href=\"https://github.com/Lightning-AI/pytorch-lightning/pull/19915\">Lightning-AI#19915</a>)"}},{"before":"2ba728f4daf3ad8d91f332b787cc3b9ab57176ad","after":"056be5da460a628bcb3814ad74b348f5aec44853","ref":"refs/heads/master","pushedAt":"2024-06-18T22:36:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"liambsmith","name":null,"path":"/liambsmith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3461091?s=80&v=4"},"commit":{"message":"Fixed minor typo","shortMessageHtmlLink":"Fixed minor typo"}},{"before":"1e83a1bd32a29e1c8802d0593dbcd6e6b173a8d3","after":"7c81f8e9d41f092bccf26ca85959fa2c79747829","ref":"refs/heads/patch-2","pushedAt":"2024-06-18T22:31:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"liambsmith","name":null,"path":"/liambsmith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3461091?s=80&v=4"},"commit":{"message":"Fixed typo","shortMessageHtmlLink":"Fixed typo"}},{"before":"098a964d75fac72d682bbb669330103711fee20a","after":"2ba728f4daf3ad8d91f332b787cc3b9ab57176ad","ref":"refs/heads/master","pushedAt":"2024-06-18T21:04:41.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pre-commit-ci[bot]","name":null,"path":"/apps/pre-commit-ci","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/68672?s=80&v=4"},"commit":{"message":"[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci","shortMessageHtmlLink":"[pre-commit.ci] auto fixes from pre-commit.com hooks"}},{"before":"1e83a1bd32a29e1c8802d0593dbcd6e6b173a8d3","after":"098a964d75fac72d682bbb669330103711fee20a","ref":"refs/heads/master","pushedAt":"2024-06-18T20:58:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"liambsmith","name":null,"path":"/liambsmith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3461091?s=80&v=4"},"commit":{"message":"Updated trainer to not call self.trainer.model during validation.\n\nBefore, using the trainer would result in:\r\n\r\nAttributeError: Your LightningModule code tried to access `self.trainer.model` but this attribute is not available when using Fabric with a LightningModule.\r\n\r\nWhich would occur during validation when 'on_validation_model_eval' and 'on_validation_model_train' were called, as they do not work with fabric. This change allows the model to be switched between train and eval mode (which the original behavior intends) without relying on calling 'self.trainer.model'. A check is added for overridden methods to not change a user's code.","shortMessageHtmlLink":"Updated trainer to not call self.trainer.model during validation."}},{"before":"c1af4d05279af7a4630d2a27b57bd85699797465","after":"1e83a1bd32a29e1c8802d0593dbcd6e6b173a8d3","ref":"refs/heads/master","pushedAt":"2024-06-18T17:51:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"liambsmith","name":null,"path":"/liambsmith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3461091?s=80&v=4"},"commit":{"message":"Check if CometLogger experiment is alive (#19915)\n\n\r\nCo-authored-by: Etay Livne <etay.livne@mobileye.com>","shortMessageHtmlLink":"Check if CometLogger experiment is alive (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2322439737\" data-permission-text=\"Title is private\" data-url=\"https://github.com/Lightning-AI/pytorch-lightning/issues/19915\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/Lightning-AI/pytorch-lightning/pull/19915/hovercard\" href=\"https://github.com/Lightning-AI/pytorch-lightning/pull/19915\">Lightning-AI#19915</a>)"}},{"before":"c1af4d05279af7a4630d2a27b57bd85699797465","after":"993953c3b97e22dd4eee17bb937c93cbb746385c","ref":"refs/heads/patch-1","pushedAt":"2024-06-17T21:19:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"liambsmith","name":null,"path":"/liambsmith","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3461091?s=80&v=4"},"commit":{"message":"Update trainer.py\n\nFix for error:\r\n\r\nTypeError: ModelHooks.on_before_optimizer_step() takes 2 positional arguments but 3 were given\r\n\r\nThe on_before_optimizer_step has no arguments, so the \", 0\" part of the call caused this error.","shortMessageHtmlLink":"Update trainer.py"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEateksAA","startCursor":null,"endCursor":null}},"title":"Activity · liambsmith/pytorch-lightning"}