Add account balance to Content Provider

[gasko]

Today you only can get the transaction amount via the content provider. But you can't get the account balance.
So I suggest that you add account balance to the category "BANK_ACCOUNTS_CAT"

[magnusart]

Short answer: This will cause tight coupling. Instead account balance should be exposed!

Long answer:
The bank balance is calculated on the fly and only saved in the database for the purpose to trigger notifications and update the database if and only if the balance have changed.

The bank balance is not a part of the domain/datamodel per se, it is actually a saved state calculated from the accounts. When UID is implemented the bank balance value does not need to be saved in the database anymore. Exposing it would cause tight coupling with any application that uses it.

Therefore the AccountBalance column should be exposed instead. I actually happen to need that as well so I will implement it.

Below is the code that uses the balance (the diff variable):

currentBalance = bank.getBalance();
accounts.clear();
for (final Account account : bank.getAccounts()) {
    accounts.put(account.getId(), account);
}
bank.update();
diff = currentBalance.subtract(bank.getBalance());

The balance itself is calculated on the fly

    public BigDecimal getBalance() {
        if (STATIC_BALANCE) {
            return balance;
        }
        else {
            BigDecimal bal = new BigDecimal(0); 
            for (Account account : accounts) {
                if (account.getType() == Account.REGULAR || account.getType() == Account.CCARD) {
                    if (!account.isHidden() || (account.getAliasfor() == null || account.getAliasfor().length() == 0)) {
                        bal = bal.add(account.getBalance());
                    }
                }
            }
            return bal;
        }
    }

[magnusart]

Hmmm.... very tired and misread the original question. Embarrasing but anyhow, I'm almost done implementing it.

[magnusart]

This is implemented in a pending pull request: #89

[liato]

Thanks magnusart!