Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement gh actions workflow #1054

Merged
merged 4 commits into from Sep 2, 2021
Merged

implement gh actions workflow #1054

merged 4 commits into from Sep 2, 2021

Conversation

@michaelshobbs
Copy link
Contributor

@michaelshobbs michaelshobbs commented Sep 1, 2021

ref: #1047 (comment)

the TestSSLClientCertificates fails on postgres 13 & 12 with ssl_test.go:269: remote error: tls: bad certificate but the other postgres versions seem to work.

EDIT: also TestSSLVerifyFull fails on golang 1.17 with ssl_test.go:104: x509: certificate relies on legacy Common Name field, use SANs instead. From what I can tell, they removed the GODEBUG=x509ignoreCN=0 flag.

@michaelshobbs
Copy link
Contributor Author

@michaelshobbs michaelshobbs commented Sep 1, 2021

@otan @mjibson I'm not an SSL expert by any stretch so any pointers here would be great

@otan
Copy link
Collaborator

@otan otan commented Sep 1, 2021

i'm no expert either, but my guess is those certificates have to be regenerated. maybe worth following https://www.postgresql.org/docs/current/ssl-tcp.html.

this is looking awesome btw!

@michaelshobbs michaelshobbs force-pushed the feature/gh-actions branch from 8980c1c to b81abde Sep 2, 2021
@michaelshobbs
Copy link
Contributor Author

@michaelshobbs michaelshobbs commented Sep 2, 2021

@otan @mjibson i believe this is good to go now

Makefile Outdated Show resolved Hide resolved
@michaelshobbs
Copy link
Contributor Author

@michaelshobbs michaelshobbs commented Sep 2, 2021

once this is merged, i'll update #1047 with these commits

@otan
Copy link
Collaborator

@otan otan commented Sep 2, 2021

this is awesome, cheers buddy

@otan otan merged commit 2140507 into lib:master Sep 2, 2021
20 checks passed
@michaelshobbs michaelshobbs deleted the feature/gh-actions branch Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants