Add support for sslrootcert #226

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

cmelbye commented Jan 30, 2014

This pull request adds support for the sslrootcert connection option as well as the PGSSLROOTCERT environment variable.

Contributor

uhoh-itsmaciek commented Feb 3, 2014

Thanks, I think this looks reasonable. Have you seen the related #208? I don't think there are any conflicts (at least not conceptually, there might be merge conflicts), but it's probably good to be aware of this. Also, you should add this to the list of connection parameters in doc.go.

Is there a reasonable way to test this in Travis CI? Some of the test directions from #208 may be useful there, although I have to say I haven't gotten that to work yet (though other maintainers have).

Contributor

johto commented Jul 29, 2014

@cmelbye: What's your status? I'd like to merge #274 soonish. I can work on the Travis tests if you'd prefer not to.

Contributor

cmelbye commented Aug 5, 2014

Yeah, I may not have time to add tests for this this week. Sorry about that.

@johto johto self-assigned this Oct 11, 2014

Contributor

johto commented Oct 11, 2014

OK, now that #208 is in, we should have all the pieces to get this one in as well. I'm going to need a small break first, though.

Contributor

johto commented Oct 12, 2014

OK; pushed with tests for verify-full in b6ee44d. Thanks, @cmelbye!

@johto johto closed this Oct 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment