Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libLAS uses deprecated BOOST_BIG_ENDIAN #165

Closed
dobrypd opened this issue Apr 24, 2019 · 2 comments
Closed

libLAS uses deprecated BOOST_BIG_ENDIAN #165

dobrypd opened this issue Apr 24, 2019 · 2 comments

Comments

@dobrypd
Copy link
Contributor

dobrypd commented Apr 24, 2019

Starting with boost 1.69.0 BOOST_BIG_ENDIAN is deprecated.

It is used here: https://github.com/libLAS/libLAS/blob/1.8.1/include/liblas/detail/binary.hpp#L46

Commit in boost:
boostorg/predef@32d4581

Maybe boost dependency can be removed from binary.hpp, and https://github.com/libLAS/libLAS/blob/1.8.1/include/liblas/detail/endian.hpp can be used?

Version: 1.8.1
@dobrypd dobrypd changed the title Liblass uses depreciated BOOST_BIG_ENDIAN libLAS uses depreciated BOOST_BIG_ENDIAN Apr 24, 2019
@dobrypd dobrypd changed the title libLAS uses depreciated BOOST_BIG_ENDIAN libLAS uses deprecated BOOST_BIG_ENDIAN Apr 24, 2019
@mloskot
Copy link
Member

mloskot commented Apr 24, 2019

I guess BOOST_BIG_ENDIAN has been left unnoticed.
It seems a good idea indeed to replace with LIBLAS_BIG_ENDIAN and our endian.hpp.

Would you be interested to submit PR with such refactoring?

@dobrypd
Copy link
Contributor Author

dobrypd commented Apr 25, 2019

I can do it.

@dobrypd dobrypd mentioned this issue Apr 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mloskot @dobrypd